public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	jaswinder@kernel.org, jaswinderrajput@gmail.com,
	fweisbec@gmail.com, hpa@kernel.org, rostedt@goodmis.org,
	tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/syscalls] x86: entry_32.S fix compile warnings - fix work mask bit width
Date: Sat, 14 Mar 2009 11:13:59 +0300	[thread overview]
Message-ID: <20090314081359.GA7405@localhost> (raw)
In-Reply-To: <tip-95baa1a17ff80183317d815189fe1f12fdb653bc@git.kernel.org>

[Jaswinder Singh Rajput - Sat, Mar 14, 2009 at 07:18:32AM +0000]
| Commit-ID:  95baa1a17ff80183317d815189fe1f12fdb653bc
| Gitweb:     http://git.kernel.org/tip/95baa1a17ff80183317d815189fe1f12fdb653bc
| Author:     Jaswinder Singh Rajput <jaswinder@kernel.org>
| AuthorDate: Sat, 14 Mar 2009 12:08:13 +0530
| Commit:     Ingo Molnar <mingo@elte.hu>
| CommitDate: Sat, 14 Mar 2009 08:16:01 +0100
| 
| x86: entry_32.S fix compile warnings - fix work mask bit width
| 
| Fix:
| 
|  arch/x86/kernel/entry_32.S:446: Warning: 00000000080001d1 shortened to 00000000000001d1
|  arch/x86/kernel/entry_32.S:457: Warning: 000000000800feff shortened to 000000000000feff
|  arch/x86/kernel/entry_32.S:527: Warning: 00000000080001d1 shortened to 00000000000001d1
|  arch/x86/kernel/entry_32.S:541: Warning: 000000000800feff shortened to 000000000000feff
|  arch/x86/kernel/entry_32.S:676: Warning: 0000000008000091 shortened to 0000000000000091
| 
| TIF_SYSCALL_FTRACE is 0x08000000 and until now we checked the
| first 16 bits of the work mask - bit 27 falls outside of that.
| 
| Update the entry_32.S code to check the full 32-bit mask.
| 
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
| Cc: Frederic Weisbecker <fweisbec@gmail.com>
| Cc: Steven Rostedt <rostedt@goodmis.org>
| Cc: "H. Peter Anvin" <hpa@kernel.org>
| LKML-Reference: <1237012693.18733.3.camel@ht.satnam>
| Signed-off-by: Ingo Molnar <mingo@elte.hu>
| 
| 
| ---
|  arch/x86/kernel/entry_32.S |   18 ++++++++----------
|  1 files changed, 8 insertions(+), 10 deletions(-)
| 
...  
|  sysexit_audit:
| -	testw $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %cx
| +	testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %cx
							^^^^^
Better to point ecx here? :)

	- Cyrill -

  reply	other threads:[~2009-03-14  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-14  6:38 [PATCH -tip] x86: entry_32.S fix compiling warnings Jaswinder Singh Rajput
2009-03-14  7:14 ` Ingo Molnar
2009-03-14  7:18 ` [tip:tracing/syscalls] x86: entry_32.S fix compile warnings - fix work mask bit width Jaswinder Singh Rajput
2009-03-14  8:13   ` Cyrill Gorcunov [this message]
2009-03-14  8:29     ` Jaswinder Singh Rajput
2009-03-14  8:45 ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090314081359.GA7405@localhost \
    --to=gorcunov@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jaswinder@kernel.org \
    --cc=jaswinderrajput@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox