From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
laijs@cn.fujitsu.com, pmarques@grupopie.com, srostedt@redhat.com,
fweisbec@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] kallsyms, tracing: output more proper symbol name
Date: Sat, 14 Mar 2009 09:54:33 +0100 [thread overview]
Message-ID: <20090314085433.GA14513@elte.hu> (raw)
In-Reply-To: <20090313130722.1d92ad80.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 13 Mar 2009 20:40:13 +0100
> Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > > This patch puts symbols like "__irqentry_text_start" to the second
> > > aliased symbols. And a more proper symbol name becomes the first.
> > >
> > > Aliased symbols mostly come from linker script. The solution is
> > > guessing "is this symbol defined in linker script", the symbols
> > > defined in linker script will not become the first aliased symbol.
> > >
> > > And if symbols are found to be equal in this "linker script provided"
> > > criteria, symbols are sorted by the number of prefix underscores.
> > >
> > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> >
> > Looks good to me.
> >
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> So... do we need this in 2.6.29?
no. This got raised in the context of new tracing changes queued
up for 2.6.30.
Ingo
next prev parent reply other threads:[~2009-03-14 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 9:37 [PATCH] kallsyms, tracing: output more proper symbol name Lai Jiangshan
2009-03-11 9:46 ` Ingo Molnar
2009-03-11 10:29 ` Frederic Weisbecker
2009-03-11 13:05 ` Paulo Marques
2009-03-12 2:43 ` Lai Jiangshan
2009-03-12 15:32 ` Paulo Marques
2009-03-13 7:10 ` [PATCH V3] " Lai Jiangshan
2009-03-13 9:27 ` Lai Jiangshan
2009-03-13 19:25 ` Paulo Marques
2009-03-13 19:40 ` Sam Ravnborg
2009-03-13 20:07 ` Andrew Morton
2009-03-13 20:34 ` Paulo Marques
2009-03-14 8:54 ` Ingo Molnar [this message]
2009-03-14 8:57 ` [tip:tracing/ftrace] " Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314085433.GA14513@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=sam@ravnborg.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox