Re: [PATCH -tip] x86: cpu/intel.c cleanup

Ingo Molnar
2009-03-14T17:05:30Z

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> On Sat, 2009-03-14 at 16:31 +0100, Ingo Molnar wrote:
> > >
> > > I don't really like this change (last hunk). Doesn't it seem a
> > > bit pointless? It breaks the symmetry with the masked CPUID
> > > levels at the beginning of the function. If somebody wants to
> > > add something else to this function, it might have to be
> > > reindented again. Or is there a problem with too long lines
> > > here?
> >
> > yes, it would be cleaner to put the whole family 15 branch into
> > a helper inline function instead.
> >
>
> OK, better I keep it unchanged :-)

Why not implement the cleanup i suggested?

Ingo