Re: [PATCH -tip] x86: cpu/intel.c cleanup

Jaswinder Singh Rajput
2009-03-14T18:05:56Z

On Sat, 2009-03-14 at 18:04 +0100, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> > On Sat, 2009-03-14 at 16:31 +0100, Ingo Molnar wrote:
> > > >
> > > > I don't really like this change (last hunk). Doesn't it seem a
> > > > bit pointless? It breaks the symmetry with the masked CPUID
> > > > levels at the beginning of the function. If somebody wants to
> > > > add something else to this function, it might have to be
> > > > reindented again. Or is there a problem with too long lines
> > > > here?
> > >
> > > yes, it would be cleaner to put the whole family 15 branch into
> > > a helper inline function instead.
> > >
> >
> > OK, better I keep it unchanged :-)
>
> Why not implement the cleanup i suggested?

I followed your approached and made new helper function. But the result
was same, in that helper function I have to check for family 15 and rest
of things. So I found nothing was gained, So I again reverted it and
provided you this patch.

Thanks,
--
JSR