[PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[Daniel Mack]

This patch adds support to the ax88796 ethernet driver to take IRQ flags
given by the platform_device definition.

The patch depends on the platform_get_irq_flags() function which I added
in a patch posted here:

	http://lkml.org/lkml/2009/3/13/267

Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Ben Dooks <ben@simtec.co.uk>
---
 drivers/net/ax88796.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index a4eb6c4..728e17c 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -93,6 +93,7 @@ struct ax_device {
 
 	unsigned char		 running;
 	unsigned char		 resume_open;
+	unsigned int		 irqflags;
 
 	u32			 reg_offsets[0x20];
 };
@@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev)
 
 	dev_dbg(&ax->dev->dev, "%s: open\n", dev->name);
 
-	ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev);
+	ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags,
+			  dev->name, dev);
 	if (ret)
 		return ret;
 
@@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev)
 		goto exit_mem;
 	}
 	dev->irq = ret;
+	ax->irqflags = platform_get_irq_flags(pdev, 0);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (res == NULL) {
-- 
1.6.2

Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[Ben Dooks]

On Fri, Mar 13, 2009 at 03:50:51PM +0100, Daniel Mack wrote:
> This patch adds support to the ax88796 ethernet driver to take IRQ flags
> given by the platform_device definition.
> 
> The patch depends on the platform_get_irq_flags() function which I added
> in a patch posted here:
> 
> 	http://lkml.org/lkml/2009/3/13/267
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Ben Dooks <ben@simtec.co.uk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
>  drivers/net/ax88796.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index a4eb6c4..728e17c 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -93,6 +93,7 @@ struct ax_device {
>  
>  	unsigned char		 running;
>  	unsigned char		 resume_open;
> +	unsigned int		 irqflags;
>  
>  	u32			 reg_offsets[0x20];
>  };
> @@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev)
>  
>  	dev_dbg(&ax->dev->dev, "%s: open\n", dev->name);
>  
> -	ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev);
> +	ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags,
> +			  dev->name, dev);
>  	if (ret)
>  		return ret;
>  
> @@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev)
>  		goto exit_mem;
>  	}
>  	dev->irq = ret;
> +	ax->irqflags = platform_get_irq_flags(pdev, 0);
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (res == NULL) {
> -- 
> 1.6.2
> 

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[David Miller]

From: Daniel Mack <daniel@caiaq.de>
Date: Fri, 13 Mar 2009 15:50:51 +0100

> This patch adds support to the ax88796 ethernet driver to take IRQ flags
> given by the platform_device definition.
> 
> The patch depends on the platform_get_irq_flags() function which I added
> in a patch posted here:
> 
> 	http://lkml.org/lkml/2009/3/13/267
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>

Few things:

1) Send networking patches to netdev@vger.kernel.org, not linux-net
   which is for user questions.

2) That platform_get_irq_flags() does not exist in any of the networking
   trees so I cannot apply this.

Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[David Miller]

Can someone forward my reply to daniel@caiaq.de?  His site
doesn't accept emails from me because I lack reverse DNS.

Also let him know that he should get that resolved if he
wants to submit any other networking patches :-)

Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[Matti Aarnio]

On Fri, Mar 13, 2009 at 12:02:14PM -0700, David Miller wrote:
> 
> Can someone forward my reply to daniel@caiaq.de?  His site
> doesn't accept emails from me because I lack reverse DNS.
> 
> Also let him know that he should get that resolved if he
> wants to submit any other networking patches :-)

Done that, Dave.

You could use your privileges as VGER's user to send email
from there...

 /Matti

Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device

[Daniel Mack]

Hi,

(the reverse-DNS check is disabled now, sorry for the trouble)

On Fri, Mar 13, 2009 at 11:53:42AM -0700, David Miller wrote:
> > This patch adds support to the ax88796 ethernet driver to take IRQ flags
> > given by the platform_device definition.
> > 
> > The patch depends on the platform_get_irq_flags() function which I added
> > in a patch posted here:
> > 
> > 	http://lkml.org/lkml/2009/3/13/267
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> 
> Few things:
> 
> 1) Send networking patches to netdev@vger.kernel.org, not linux-net
>    which is for user questions.

Ok, wasn't aware of that, sorry.

> 2) That platform_get_irq_flags() does not exist in any of the networking
>    trees so I cannot apply this.

Jep, the other one would need to me merged first. Could you ack on the
patch[*] in case you're fine with it?

Thanks,
Daniel

[*] http://lkml.org/lkml/2009/3/13/267