* Re: [tip:core/printk] fix regression from "vsprintf: unify the format decoding layer for its 3 users"
[not found] <tip-adf26f84a62b492e002d3b75af671f23ddd3be0a@git.kernel.org>
@ 2009-03-15 14:54 ` Frederic Weisbecker
0 siblings, 0 replies; only message in thread
From: Frederic Weisbecker @ 2009-03-15 14:54 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, torvalds, vegard.nossum, jeremy, tglx,
mingo
Cc: linux-tip-commits
On Sat, Mar 14, 2009 at 11:39:47AM +0000, Vegard Nossum wrote:
> Commit-ID: adf26f84a62b492e002d3b75af671f23ddd3be0a
> Gitweb: http://git.kernel.org/tip/adf26f84a62b492e002d3b75af671f23ddd3be0a
> Author: Vegard Nossum <vegard.nossum@gmail.com>
> AuthorDate: Sat, 14 Mar 2009 12:08:50 +0100
> Commit: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sat, 14 Mar 2009 12:37:08 +0100
>
> fix regression from "vsprintf: unify the format decoding layer for its 3 users"
>
> Jeremy Fitzhardinge reported:
>
> > Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf:
> > unify the format decoding layer for its 3 users", causes a
> > regression in xenbus which results in no devices getting
> > attached to a new domain.
>
> %.*s is broken - fix it.
>
> Reported-by: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
>
> ---
> lib/vsprintf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index dc16743..708e505 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -843,7 +843,7 @@ precision:
> spec->precision = 0;
> } else if (*fmt == '*') {
> /* it's the next argument */
> - spec->type = FORMAT_TYPE_WITDH;
> + spec->type = FORMAT_TYPE_PRECISION;
> return ++fmt - start;
> }
> }
Thanks a lot for this patch!
Frederic.
^ permalink raw reply [flat|nested] only message in thread