public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()
@ 2009-03-12  7:45 Wu Fengguang
  2009-03-16  2:59 ` Len Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Wu Fengguang @ 2009-03-12  7:45 UTC (permalink / raw)
  To: Andrew Morton
  Cc: LKML, ACPI Devel Maling List, Rusty Russell, Ingo Molnar,
	Venkatesh Pallipadi, Len Brown, Zhao Yakui

This fixes a NULL pointer dereference bug introduced by 6e911954cac.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
index 6626e8c..b866b87 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
 	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
 
 	retval = smp_call_function_single(cpu,
-				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
+				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
 	if (retval == 0) {
 		retval = cxcc.retval;
 		if (retval == 0) {

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()
  2009-03-12  7:45 [PATCH] ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu() Wu Fengguang
@ 2009-03-16  2:59 ` Len Brown
  2009-03-16  4:43   ` Wu Fengguang
  0 siblings, 1 reply; 3+ messages in thread
From: Len Brown @ 2009-03-16  2:59 UTC (permalink / raw)
  To: Wu Fengguang
  Cc: Andrew Morton, LKML, ACPI Devel Maling List, Rusty Russell,
	Ingo Molnar, Venkatesh Pallipadi, Len Brown, Zhao Yakui

On Thu, 12 Mar 2009, Wu Fengguang wrote:

> This fixes a NULL pointer dereference bug introduced by 6e911954cac.

What tree is this patch on top of?

thanks,
-Len Brown
Intel Open Source Technology Center

> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> index 6626e8c..b866b87 100644
> --- a/arch/x86/kernel/acpi/cstate.c
> +++ b/arch/x86/kernel/acpi/cstate.c
> @@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
>  	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
>  
>  	retval = smp_call_function_single(cpu,
> -				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
> +				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
>  	if (retval == 0) {
>  		retval = cxcc.retval;
>  		if (retval == 0) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()
  2009-03-16  2:59 ` Len Brown
@ 2009-03-16  4:43   ` Wu Fengguang
  0 siblings, 0 replies; 3+ messages in thread
From: Wu Fengguang @ 2009-03-16  4:43 UTC (permalink / raw)
  To: Len Brown
  Cc: Andrew Morton, LKML, ACPI Devel Maling List, Rusty Russell,
	Ingo Molnar, Pallipadi, Venkatesh, Brown, Len, Zhao, Yakui

On Mon, Mar 16, 2009 at 10:59:19AM +0800, Len Brown wrote:
> On Thu, 12 Mar 2009, Wu Fengguang wrote:
> 
> > This fixes a NULL pointer dereference bug introduced by 6e911954cac.
> 
> What tree is this patch on top of?

It's for 2.6.29-rc7-next-20090311. Already fixed in other trees?

Thanks,
Fengguang

> thanks,
> -Len Brown
> Intel Open Source Technology Center
> 
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> > ---
> > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> > index 6626e8c..b866b87 100644
> > --- a/arch/x86/kernel/acpi/cstate.c
> > +++ b/arch/x86/kernel/acpi/cstate.c
> > @@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
> >  	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
> >  
> >  	retval = smp_call_function_single(cpu,
> > -				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
> > +				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
> >  	if (retval == 0) {
> >  		retval = cxcc.retval;
> >  		if (retval == 0) {
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-03-16  4:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-12  7:45 [PATCH] ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu() Wu Fengguang
2009-03-16  2:59 ` Len Brown
2009-03-16  4:43   ` Wu Fengguang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox