From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757750AbZCPIep (ORCPT ); Mon, 16 Mar 2009 04:34:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752615AbZCPIef (ORCPT ); Mon, 16 Mar 2009 04:34:35 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:57005 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753589AbZCPIee (ORCPT ); Mon, 16 Mar 2009 04:34:34 -0400 Date: Mon, 16 Mar 2009 04:34:27 -0400 From: Christoph Hellwig To: Linus Torvalds Cc: Laurent GUERBY , linux-kernel , OGAWA Hirofumi Subject: Re: [2.6.29-rc5][BUG] swapon on vfat file gets stuck on inode lock Message-ID: <20090316083427.GA3685@infradead.org> References: <1236779832.11347.2082.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2009 at 08:53:14AM -0700, Linus Torvalds wrote: > I dunno. No other filesystem has _any_ locking in their bmap that I can > see, so I strongly suspect that fat doesn't need it either. XFS has proper locking using it's own locks. Then again Peter had patchset somewhere to implement proper aops for swap instead of abusing -bmap to implement swap over NFS, which should be able to fix this for fat, too.