public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: mike.miller@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH trivial] cpqarray: enable bus mastering
Date: Mon, 16 Mar 2009 10:05:24 +0100	[thread overview]
Message-ID: <20090316090524.GM27476@kernel.dk> (raw)
In-Reply-To: <20090315053842.GI3167@bombadil.infradead.org>

On Sun, Mar 15 2009, Kyle McMartin wrote:
> From: Dave Jones <davej@redhat.com>
> 
> We've been carrying this patch for the last 3 years in Fedora,
> long past time we got it upstream...
> 
> Call pci_set_master to enable bus-mastering if the BIOS hasn't
> done it already.
> 
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- a/drivers/block/cpqarray.c	2006-10-06 14:23:34.000000000 -0400
> +++ b/drivers/block/cpqarray.c	2006-10-06 14:25:16.000000000 -0400
> @@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
>  	int i;
>  
>  	c->pci_dev = pdev;
> +	pci_set_master(pdev);
>  	if (pci_enable_device(pdev)) {
>  		printk(KERN_ERR "cpqarray: Unable to Enable PCI device\n");
>  		return -1;

Thanks Kyle, looks pretty innocent. Queued up for 2.6.30.

-- 
Jens Axboe


  reply	other threads:[~2009-03-16  9:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15  5:38 [PATCH trivial] cpqarray: enable bus mastering Kyle McMartin
2009-03-16  9:05 ` Jens Axboe [this message]
2009-03-16 15:45   ` Miller, Mike (OS Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316090524.GM27476@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=kyle@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox