* [PATCH trivial] cpqarray: enable bus mastering
@ 2009-03-15 5:38 Kyle McMartin
2009-03-16 9:05 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2009-03-15 5:38 UTC (permalink / raw)
To: axboe; +Cc: mike.miller, linux-kernel
From: Dave Jones <davej@redhat.com>
We've been carrying this patch for the last 3 years in Fedora,
long past time we got it upstream...
Call pci_set_master to enable bus-mastering if the BIOS hasn't
done it already.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
Signed-off-by: Dave Jones <davej@redhat.com>
--- a/drivers/block/cpqarray.c 2006-10-06 14:23:34.000000000 -0400
+++ b/drivers/block/cpqarray.c 2006-10-06 14:25:16.000000000 -0400
@@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
int i;
c->pci_dev = pdev;
+ pci_set_master(pdev);
if (pci_enable_device(pdev)) {
printk(KERN_ERR "cpqarray: Unable to Enable PCI device\n");
return -1;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH trivial] cpqarray: enable bus mastering
2009-03-15 5:38 [PATCH trivial] cpqarray: enable bus mastering Kyle McMartin
@ 2009-03-16 9:05 ` Jens Axboe
2009-03-16 15:45 ` Miller, Mike (OS Dev)
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2009-03-16 9:05 UTC (permalink / raw)
To: Kyle McMartin; +Cc: mike.miller, linux-kernel
On Sun, Mar 15 2009, Kyle McMartin wrote:
> From: Dave Jones <davej@redhat.com>
>
> We've been carrying this patch for the last 3 years in Fedora,
> long past time we got it upstream...
>
> Call pci_set_master to enable bus-mastering if the BIOS hasn't
> done it already.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- a/drivers/block/cpqarray.c 2006-10-06 14:23:34.000000000 -0400
> +++ b/drivers/block/cpqarray.c 2006-10-06 14:25:16.000000000 -0400
> @@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
> int i;
>
> c->pci_dev = pdev;
> + pci_set_master(pdev);
> if (pci_enable_device(pdev)) {
> printk(KERN_ERR "cpqarray: Unable to Enable PCI device\n");
> return -1;
Thanks Kyle, looks pretty innocent. Queued up for 2.6.30.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH trivial] cpqarray: enable bus mastering
2009-03-16 9:05 ` Jens Axboe
@ 2009-03-16 15:45 ` Miller, Mike (OS Dev)
0 siblings, 0 replies; 3+ messages in thread
From: Miller, Mike (OS Dev) @ 2009-03-16 15:45 UTC (permalink / raw)
To: Jens Axboe, Kyle McMartin; +Cc: linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Jens Axboe [mailto:jens.axboe@oracle.com]
> Sent: Monday, March 16, 2009 4:05 AM
> To: Kyle McMartin
> Cc: Miller, Mike (OS Dev); linux-kernel@vger.kernel.org
> Subject: Re: [PATCH trivial] cpqarray: enable bus mastering
>
> On Sun, Mar 15 2009, Kyle McMartin wrote:
> > From: Dave Jones <davej@redhat.com>
> >
> > We've been carrying this patch for the last 3 years in Fedora, long
> > past time we got it upstream...
> >
> > Call pci_set_master to enable bus-mastering if the BIOS
> hasn't done it
> > already.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> > Signed-off-by: Dave Jones <davej@redhat.com>
> >
> > --- a/drivers/block/cpqarray.c 2006-10-06
> 14:23:34.000000000 -0400
> > +++ b/drivers/block/cpqarray.c 2006-10-06
> 14:25:16.000000000 -0400
> > @@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
> > int i;
> >
> > c->pci_dev = pdev;
> > + pci_set_master(pdev);
> > if (pci_enable_device(pdev)) {
> > printk(KERN_ERR "cpqarray: Unable to Enable PCI
> device\n");
> > return -1;
>
> Thanks Kyle, looks pretty innocent. Queued up for 2.6.30.
>
> --
> Jens Axboe
Reviewed-by: Mike Miller <mike.miller@hp.com>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-16 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-15 5:38 [PATCH trivial] cpqarray: enable bus mastering Kyle McMartin
2009-03-16 9:05 ` Jens Axboe
2009-03-16 15:45 ` Miller, Mike (OS Dev)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox