[PATCH 3/3] tracing: stop comm recording on tracing off

Steven Rostedt
2009-03-17T03:50:21Z

[-- Attachment #1: 0003-tracing-stop-comm-recording-on-tracing-off.patch --]
[-- Type: text/plain, Size: 1071 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

Impact: fix for losing comms in trace

The command lines of tasks are cached at sched switch to not need
to record them at every trace point. Disabling the tracing on stops
the recording of traces, but does not stop the caching of command lines.
When the tracing is off the cache may overflow and cause the tracing
to show incorrect tasks matching the PIDs.

This patch disables prevents updates to the comm cache when the ring buffer
is off.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 2796bd2..8f89690 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -797,7 +797,7 @@ void trace_find_cmdline(int pid, char comm[])

void tracing_record_cmdline(struct task_struct *tsk)
{
- if (atomic_read(&trace_record_cmdline_disabled))
+ if (atomic_read(&trace_record_cmdline_disabled) || !tracing_is_on())
return;

trace_save_cmdline(tsk);
--
1.6.2

--