From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Theodore Tso <tytso@mit.edu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"Martin J. Bligh" <mbligh@mbligh.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Larry Woodman <lwoodman@redhat.com>,
Jason Baron <jbaron@redhat.com>, Tom Zanussi <tzanussi@gmail.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Jiaying Zhang <jiayingz@google.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 2/7] tracing: replace TP<var> with TP_<var>
Date: Tue, 17 Mar 2009 03:58:52 -0400 [thread overview]
Message-ID: <20090317075852.GA9960@infradead.org> (raw)
In-Reply-To: <20090310045810.833427485@goodmis.org>
On Tue, Mar 10, 2009 at 12:57:12AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> Impact: clean up
>
> The macros TPPROTO, TPARGS, TPFMT, TPRAWFMT, and TPCMD all look a bit
> ugly. This patch adds an underscore to their names.
Honestly I think they still look ugly.
> DECLARE_TRACE(subsys_eventname,
> - TPPROTO(int firstarg, struct task_struct *p),
> - TPARGS(firstarg, p));
> + TP_PROTO(int firstarg, struct task_struct *p),
> + TP_ARGS(firstarg, p));
Compare that to a
DECLARE_TRACE(subsys_eventname,
trace_proto(int firstarg, struct task_struct *p),
trace_args(firstarg, p));
or even when you insist on UPPERCASE:
DECLARE_TRACE(subsys_eventname,
TRACE_PROTO(int firstarg, struct task_struct *p),
TRACE_ARGS(firstarg, p));
next prev parent reply other threads:[~2009-03-17 7:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 4:57 [PATCH 0/7] [GIT PULL] enhancements for tracing in tip Steven Rostedt
2009-03-10 4:57 ` [PATCH 1/7] tracing: typecast sizeof and offsetof to unsigned int Steven Rostedt
2009-03-10 5:20 ` Andrew Morton
2009-03-10 13:39 ` Steven Rostedt
2009-03-10 4:57 ` [PATCH 2/7] tracing: replace TP<var> with TP_<var> Steven Rostedt
2009-03-17 7:58 ` Christoph Hellwig [this message]
2009-03-17 15:30 ` Steven Rostedt
2009-03-10 4:57 ` [PATCH 3/7] tracing: use generic __stringify Steven Rostedt
2009-03-10 10:56 ` Frederic Weisbecker
2009-03-10 11:18 ` KOSAKI Motohiro
2009-03-10 11:21 ` Peter Zijlstra
2009-03-10 15:48 ` Frédéric Weisbecker
2009-03-10 4:57 ` [PATCH 4/7] tracing: new format for specialized trace points Steven Rostedt
2009-03-10 5:50 ` KOSAKI Motohiro
2009-03-10 8:54 ` Ingo Molnar
2009-03-10 13:45 ` Steven Rostedt
2009-03-10 9:54 ` KOSAKI Motohiro
2009-03-10 13:55 ` Steven Rostedt
2009-03-17 8:08 ` Christoph Hellwig
2009-03-17 15:41 ` Steven Rostedt
2009-03-10 4:57 ` [PATCH 5/7] tracing: convert the sched trace points to the TRACE_EVENT macros Steven Rostedt
2009-03-10 4:57 ` [PATCH 6/7] tracing: convert irq trace points to new macros Steven Rostedt
2009-03-10 4:57 ` [PATCH 7/7] tracing: remove obsolete TRACE_EVENT_FORMAT macro Steven Rostedt
2009-03-17 8:08 ` Christoph Hellwig
2009-03-10 8:59 ` [PATCH 0/7] [GIT PULL] enhancements for tracing in tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317075852.GA9960@infradead.org \
--to=hch@infradead.org \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mbligh@mbligh.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox