From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhang Le <r0bertz@gentoo.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org, alan@redhat.com
Subject: Re: [PATCH] filp->f_pos not correctly updated in proc_task_readdir
Date: Tue, 17 Mar 2009 18:11:14 +0000 [thread overview]
Message-ID: <20090317181114.GW28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090317125346.GA22268@adriano.hkcable.com.hk>
On Tue, Mar 17, 2009 at 08:53:47PM +0800, Zhang Le wrote:
> > > way to go.
> >
> > Except this bit:
> >
> > fs/built-in.o: In function `proc_task_readdir':
> > compr_zlib.c:(.text+0x434b8): undefined reference to `__cmpdi2'
> > compr_zlib.c:(.text+0x434d4): undefined reference to `__cmpdi2'
>
> Hi, I am sorry but I can't reproduce this.
> Are you sure this only happens after applying my patch?
> Would you please provide your fs/jffs2/compr_zlib.o and fs/proc/base.o?
> And what is your gcc version? I am using gcc 4.4 snapshot rev. 144705
The critical part is target architecture, not version... switch on
long long ends up spewing library calls. It's switch (pos) that
became switch (file->f_pos).
next prev parent reply other threads:[~2009-03-17 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 6:44 [PATCH] filp->f_pos not correctly updated in proc_task_readdir Zhang Le
2009-03-16 8:34 ` Al Viro
2009-03-16 16:27 ` Zhang Le
2009-03-17 10:37 ` Alexey Dobriyan
2009-03-17 12:53 ` Zhang Le
2009-03-17 13:48 ` Alexey Dobriyan
2009-03-17 18:11 ` Al Viro [this message]
2009-03-17 18:12 ` Eric W. Biederman
2009-03-18 7:27 ` Zhang Le
2009-03-18 10:36 ` Eric W. Biederman
2009-03-18 13:39 ` [PATCH] proc: Fix proc_tid_readdir so it handles the weird cases Eric W. Biederman
2009-03-18 13:57 ` Louis Rilling
2009-03-19 3:40 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090317181114.GW28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r0bertz@gentoo.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox