public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arjan van de Ven <arjan@infradead.org>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 2/5] tracing: add global-clock option to provide cross CPU clock to traces
Date: Tue, 17 Mar 2009 23:14:25 -0400	[thread overview]
Message-ID: <20090318033249.216553481@goodmis.org> (raw)
In-Reply-To: 20090318031423.981603258@goodmis.org

[-- Attachment #1: 0002-tracing-add-global-clock-option-to-provide-cross-CP.patch --]
[-- Type: text/plain, Size: 2259 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

Impact: feature to allow better serialized clock

This patch adds an option called "global-clock" that will allow
the tracer to switch to a slower but more accurate (across CPUs)
clock.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 kernel/trace/trace.c |   34 ++++++++++++++++++++++++++++++----
 kernel/trace/trace.h |    1 +
 2 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 3be2f78..2f994ca 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -315,6 +315,7 @@ static const char *trace_options[] = {
 	"printk-msg-only",
 	"context-info",
 	"latency-format",
+	"global-clock",
 	NULL
 };
 
@@ -2251,6 +2252,34 @@ static int set_tracer_option(struct tracer *trace, char *cmp, int neg)
 	return 0;
 }
 
+static void set_tracer_flags(unsigned int mask, int enabled)
+{
+	/* do nothing if flag is already set */
+	if (!!(trace_flags & mask) == !!enabled)
+		return;
+
+	if (enabled)
+		trace_flags |= mask;
+	else
+		trace_flags &= ~mask;
+
+	if (mask == TRACE_ITER_GLOBAL_CLK) {
+		u64 (*func)(void);
+
+		if (enabled)
+			func = trace_clock_global;
+		else
+			func = trace_clock_local;
+
+		mutex_lock(&trace_types_lock);
+		ring_buffer_set_clock(global_trace.buffer, func);
+
+		if (max_tr.buffer)
+			ring_buffer_set_clock(max_tr.buffer, func);
+		mutex_unlock(&trace_types_lock);
+	}
+}
+
 static ssize_t
 tracing_trace_options_write(struct file *filp, const char __user *ubuf,
 			size_t cnt, loff_t *ppos)
@@ -2278,10 +2307,7 @@ tracing_trace_options_write(struct file *filp, const char __user *ubuf,
 		int len = strlen(trace_options[i]);
 
 		if (strncmp(cmp, trace_options[i], len) == 0) {
-			if (neg)
-				trace_flags &= ~(1 << i);
-			else
-				trace_flags |= (1 << i);
+			set_tracer_flags(1 << i, !neg);
 			break;
 		}
 	}
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index b0ecad8..26a7a28 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -667,6 +667,7 @@ enum trace_iterator_flags {
 	TRACE_ITER_PRINTK_MSGONLY	= 0x10000,
 	TRACE_ITER_CONTEXT_INFO		= 0x20000, /* Print pid/cpu/time */
 	TRACE_ITER_LATENCY_FMT		= 0x40000,
+	TRACE_ITER_GLOBAL_CLK		= 0x80000,
 };
 
 /*
-- 
1.6.2

-- 

  parent reply	other threads:[~2009-03-18  3:33 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  3:14 [PATCH 0/5] [GIT PULL] updates for tip/tracing/ftrace Steven Rostedt
2009-03-18  3:14 ` [PATCH 1/5] ring-buffer: add api to allow a tracer to change clock source Steven Rostedt
2009-03-18  3:14 ` Steven Rostedt [this message]
2009-03-18  3:14 ` [PATCH 3/5] tracing: optimization of branch tracer Steven Rostedt
2009-03-18  3:14 ` [PATCH 4/5] tracing: make sched_switch stop/start light weight Steven Rostedt
2009-03-18  3:14 ` [PATCH 5/5] tracing: make power tracer start/stop methods lighter weight Steven Rostedt
2009-03-18  5:59 ` [PATCH 0/5] [GIT PULL] updates for tip/tracing/ftrace Ingo Molnar
2009-03-18  7:39   ` Ingo Molnar
2009-03-19  7:33     ` Ingo Molnar
2009-03-19 17:21       ` Steven Rostedt
2009-03-20 17:43         ` Paul E. McKenney
2009-03-20 18:36           ` Ingo Molnar
2009-03-20 18:38             ` Ingo Molnar
2009-03-20 19:19               ` Paul E. McKenney
2009-03-20 19:27                 ` Ingo Molnar
2009-03-20 19:41                   ` Paul E. McKenney
2009-03-20 19:46                   ` Frederic Weisbecker
2009-03-20 19:54                     ` Ingo Molnar
2009-03-20 20:48                       ` Frederic Weisbecker
2009-03-20 21:05                         ` Steven Rostedt
2009-03-21 10:01                           ` Ingo Molnar
2009-03-21 16:58                             ` Ingo Molnar
2009-03-21 17:25                               ` Steven Rostedt
2009-03-21 19:07                                 ` Paul E. McKenney
2009-03-21 20:09                                   ` Ingo Molnar
2009-03-21 21:01                                     ` Paul E. McKenney
2009-03-22 14:24                                       ` Ingo Molnar
2009-03-22 15:06                                         ` Ingo Molnar
2009-03-22 17:02                                           ` Ingo Molnar
2009-03-22 18:33                                             ` Steven Rostedt
2009-03-22 19:52                                               ` Ingo Molnar
2009-03-23 18:44                                           ` Steven Rostedt
2009-03-21 17:32                               ` Frederic Weisbecker
2009-03-21 17:44                                 ` Steven Rostedt
2009-03-21 17:53                                   ` Frederic Weisbecker
2009-03-21 18:17                                     ` Steven Rostedt
2009-03-21 20:03                                       ` Frederic Weisbecker
2009-03-21 18:18                                 ` Ingo Molnar
2009-03-21 20:09                                   ` Frederic Weisbecker
2009-03-21 20:46                                     ` Frederic Weisbecker
2009-03-22 19:41                               ` Ingo Molnar
2009-03-22 20:41                                 ` Ingo Molnar
2009-03-20 21:39                         ` Paul E. McKenney
2009-03-20 17:05       ` Frederic Weisbecker
2009-03-20 17:57         ` Frederic Weisbecker
2009-03-20 18:22           ` Steven Rostedt
2009-03-20 18:39             ` Frederic Weisbecker
2009-03-20 18:42             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090318033249.216553481@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox