Re: [git-pull -tip] x86: mpparse cleanup

[Ingo Molnar <mingo@elte.hu>]

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> On Wed, 2009-03-18 at 15:11 +0100, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> > 
> > > On Wed, 2009-03-18 at 00:03 +0530, Jaswinder Singh Rajput wrote:
> > > > The following changes since commit 0ca0f16fd17c5d880dd0abbe03595b0c7c5b3c95:
> > > >   Ingo Molnar (1):
> > > >         Merge branches 'x86/apic', 'x86/asm', 'x86/cleanups', 'x86/debug', 'x86/kconfig', 'x86/mm', 'x86/ptrace', 'x86/setup' and 'x86/urgent'; commit 'v2.6.29-rc8' into x86/core
> > > > 
> > > > are available in the git repository at:
> > > > 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git x86/core
> > > > 
> > > > Jaswinder Singh Rajput (1):
> > > >       x86: mpparse cleanup
> > > > 
> > > >  arch/x86/kernel/mpparse.c |  311 +++++++++++++++++++++------------------------
> > > >  1 files changed, 146 insertions(+), 165 deletions(-)
> > > > 
> > > 
> > > Complete diff:
> > > 
> > > Subject: [PATCH] x86: mpparse cleanup
> > > 
> > > Impact: cleanup
> > > 
> > > - fix various style problems
> > >   - fix header file issues
> > 
> > These are cleanups.
> > 
> > > Introduced helper functions:
> > > skip_entry, smp_reserve_bootmem, check_irq_src and check_slot
> > 
> > These are functional modifications. (the object code changes)
> > 
> 
> OK, removed cleanups, New pull request:
> 
> The following changes since commit 0ca0f16fd17c5d880dd0abbe03595b0c7c5b3c95:
>   Ingo Molnar (1):
>         Merge branches 'x86/apic', 'x86/asm', 'x86/cleanups', 'x86/debug', 'x86/kconfig', 'x86/mm', 'x86/ptrace', 'x86/setup' and 'x86/urgent'; commit 'v2.6.29-rc8' into x86/core
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git x86/core
> 
> Jaswinder Singh Rajput (1):
>       x86: mpparse introduced few helper functions
> 
>  arch/x86/kernel/mpparse.c |  261 +++++++++++++++++++++------------------------
>  1 files changed, 120 insertions(+), 141 deletions(-)

Looks good - pulled, thanks Jaswinder!

Would you be interested in resurrecting the more mechanic cleanups 
you did as well, on top of this patch?

They are still valuable, we just have to keep them separate from a 
potential breakage-causing change like the above one, so that if a 
tester bisects to it, we have an as single-purpose and focused 
commit to look at as possible.

	Ingo