public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Chiang <achiang@hp.com>
Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [PATCH v4 07/12] PCI: Introduce /sys/bus/pci/rescan
Date: Thu, 19 Mar 2009 02:34:53 -0700	[thread overview]
Message-ID: <20090319023453.7467644a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090318224001.887.63554.stgit@bob.kio>

On Wed, 18 Mar 2009 16:40:01 -0600 Alex Chiang <achiang@hp.com> wrote:

> +#ifdef CONFIG_HOTPLUG
> +static DEFINE_MUTEX(pci_remove_rescan_mutex);
> +static ssize_t bus_rescan_store(struct bus_type *bus, const char *buf,
> +				size_t count)
> +{
> +	unsigned long val;
> +	struct pci_bus *b = NULL;
> +
> +	if (strict_strtoul(buf, 0, &val) < 0)
> +		return -EINVAL;
> +
> +	if (!capable(CAP_SYS_ADMIN))
> +		return -EPERM;
> +
> +	if (val) {
> +		mutex_lock(&pci_remove_rescan_mutex);
> +		while ((b = pci_find_next_bus(b)) != NULL)
> +			pci_rescan_bus(b);
> +		mutex_unlock(&pci_remove_rescan_mutex);
> +	}
> +	return count;
> +}
> +
> +struct bus_attribute pci_bus_attrs[] = {
> +	__ATTR(rescan, S_IWUSR, NULL, bus_rescan_store),
> +	__ATTR_NULL
> +};
> +#endif

Why CONFIG_HOTPLUG rather than CONFIG_HOTPLUG_PCI (or similar)?

  reply	other threads:[~2009-03-19  9:41 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 22:39 [PATCH v4 00/12] PCI core learns hotplug Alex Chiang
2009-03-18 22:39 ` [PATCH v4 01/12] PCI: pci_is_root_bus helper Alex Chiang
2009-03-18 22:39 ` [PATCH v4 02/12] PCI: don't scan existing devices Alex Chiang
2009-03-18 22:39 ` [PATCH v4 03/12] PCI: pci_scan_slot() returns newly found devices Alex Chiang
2009-03-18 22:39 ` [PATCH v4 04/12] PCI: always scan child buses Alex Chiang
2009-03-18 22:39 ` [PATCH v4 05/12] PCI: do not initialize bridges more than once Alex Chiang
2009-03-18 22:39 ` [PATCH v4 06/12] PCI: Introduce pci_rescan_bus() Alex Chiang
2009-03-19  9:27   ` Andrew Morton
2009-03-19 17:05     ` Alex Chiang
2009-03-19 17:42       ` Greg KH
2009-03-19 17:49         ` Alex Chiang
2009-03-19 18:09           ` Matthew Wilcox
2009-03-19 18:09           ` Greg KH
2009-03-19  9:29   ` Andrew Morton
2009-03-19 17:11     ` Alex Chiang
2009-03-18 22:40 ` [PATCH v4 07/12] PCI: Introduce /sys/bus/pci/rescan Alex Chiang
2009-03-19  9:34   ` Andrew Morton [this message]
2009-03-19 17:11     ` Alex Chiang
2009-03-19 22:55       ` Trent Piepho
2009-03-19 23:21         ` Alex Chiang
2009-03-18 22:40 ` [PATCH v4 08/12] PCI: Introduce /sys/bus/pci/devices/.../remove Alex Chiang
2009-03-19  9:43   ` Andrew Morton
2009-03-19 16:06     ` Greg KH
2009-03-19 16:30     ` Alex Chiang
2009-03-19 14:17   ` Kenji Kaneshige
2009-03-19 16:41     ` Alex Chiang
2009-03-19 20:43       ` Trent Piepho
2009-03-19 20:46         ` Alex Chiang
2009-03-19 23:19       ` Kenji Kaneshige
2009-03-20  3:53         ` Alex Chiang
2009-03-18 22:40 ` [PATCH v4 09/12] PCI: Introduce /sys/bus/pci/devices/.../rescan Alex Chiang
2009-03-18 22:40 ` [PATCH v4 10/12] PCI Hotplug: restore fakephp interface with complete reimplementation Alex Chiang
2009-03-19  9:45   ` Andrew Morton
2009-03-19 17:00     ` Alex Chiang
2009-03-19 19:24     ` Trent Piepho
2009-03-18 22:40 ` [PATCH v4 11/12] PCI Hotplug: rename legacy_fakephp to fakephp Alex Chiang
2009-03-18 22:40 ` [PATCH v4 12/12] PCI Hotplug: schedule fakephp for feature removal Alex Chiang
2009-03-19  8:12 ` [PATCH v4 00/12] PCI core learns hotplug Kenji Kaneshige
2009-03-19 17:07   ` Alex Chiang
2009-03-20  4:15   ` Alex Chiang
2009-03-19 14:09 ` Kenji Kaneshige
2009-03-19 17:13   ` Alex Chiang
2009-03-20  5:16   ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090319023453.7467644a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox