From: Ingo Molnar <mingo@elte.hu>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Restrict definition of a variable in kernel/sysctl.c
Date: Thu, 19 Mar 2009 08:25:10 +0100 [thread overview]
Message-ID: <20090319072510.GA10584@elte.hu> (raw)
In-Reply-To: <1237412967-20754-1-git-send-email-dmitri.vorobiev@movial.com>
* Dmitri Vorobiev <dmitri.vorobiev@movial.com> wrote:
> The variable "one" in kernel/sysctl.c is used only if either CONFIG_HIGHMEM,
> or CONFIG_DETECT_SOFTLOCKUP are defined (or both). Hence, if neither option
> is enabled, the following error is produced:
>
> CC kernel/sysctl.o
> kernel/sysctl.c:99: warning: 'one' defined but not used
>
> This patch fixes the warning by moving the variable definition under an
> appropriate preprocessor construct.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> ---
> kernel/sysctl.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
Note, this warning is already fixed in the tip:core/softlockup tree
and queued up for v2.6.30.
Ingo
prev parent reply other threads:[~2009-03-19 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 21:49 [PATCH 1/3] Restrict definition of a variable in kernel/sysctl.c Dmitri Vorobiev
2009-03-18 21:49 ` [PATCH 2/3] Restrict definition of a label in kernel/module.c Dmitri Vorobiev
2009-03-18 21:49 ` [PATCH 3/3] Restrict definition of a static function in kernel/auditsc.c Dmitri Vorobiev
2009-03-30 21:32 ` Andrew Morton
2009-03-19 7:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319072510.GA10584@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox