From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk
Date: Thu, 19 Mar 2009 09:17:14 +1030 [thread overview]
Message-ID: <200903190917.14780.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090318060919.GA21777@infradead.org>
On Wednesday 18 March 2009 16:39:19 Christoph Hellwig wrote:
> All backends that I checked just fail VIRTIO_BLK_T_SCSI_CMD commands, so
> AFAICS no harm is done. But should we really keep this broken support
> in the protocol around? If we do want to support packet commands in
> the future we should probably just add the command as the first S/G list
> entry.
It was pretty much a placeholder for "eject". Feel free to be the one to
define it.
But note that we chose not to use sg boundaries as part of the protocol, so
if there's going to be more than one entry, you'll need some metadata.
> Is there an actual protocol spec for virtio-blk somewhere to write these
> subtilities down? Or an list of implementations to check at least?
No, but I look forward to reading your spec :)
Thanks!
Rusty.
prev parent reply other threads:[~2009-03-18 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 6:09 VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk Christoph Hellwig
2009-03-18 6:10 ` Christoph Hellwig
2009-03-18 8:47 ` Christian Borntraeger
2009-03-18 9:16 ` Hannes Reinecke
2009-03-18 9:37 ` Christian Borntraeger
2009-03-18 9:38 ` Christoph Hellwig
2009-03-18 22:47 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903190917.14780.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox