From: Robert Schwebel <r.schwebel@pengutronix.de>
To: "Daniel Krüger" <daniel.krueger@systec-electronic.com>
Cc: Greg KH <greg@kroah.com>,
Robert Schwebel <r.schwebel@pengutronix.de>,
linux-kernel@vger.kernel.org,
Michael Olbrich <mol@pengutronix.de>,
Wolfram Sang <wsa@pengutronix.de>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: The Linux Staging tree, what it is and is not.
Date: Fri, 20 Mar 2009 09:46:36 +0100 [thread overview]
Message-ID: <20090320084636.GP5367@pengutronix.de> (raw)
In-Reply-To: <49C35515.8050808@systec-electronic.com>
On Fri, Mar 20, 2009 at 09:34:29AM +0100, Daniel Krüger wrote:
> > Sure it's questionable, and it's horrid code, but it is being used by
> > people and is the only public implementation of EPL on Linux that I
> > can find.
>
> BTW, the implementation does not follow the kernel style guide,
> because our company has its own code style guide. But what is that
> you don't like?
If you do your private stuff, you can do whatever you like. If you want
to bring something into the kernel, you have to follow the kernel style.
But it's not only a matter of coding style. Please let's not start with
implementation details as long as the overall design is unclear. So I
suggest that following Greg's advise and moving the discussion to netdev
is what we should do.
> > > Doing this kind of network protocols in kernel space may be
> > > possible in general, but IMHO the first thing that has to be done
> > > for a sane design is:
> > >
> > > "Invent proper APIs and abstractions"
> >
> > Agreed.
>
> I can only second that. But it is no easy task to find a common API
> for all field busses.
Finding a common API for all field busses is somethign we'll do on a
higher level in the OSADL Fieldbus Framework project, but in userspace.
What matters for the kernel is that, if we want to have things in
mainline, we must answer the question "what have these things in
common". It doesn't make any sense to invent infrastructure for things
that don't have anything in common. Kernel frameworks are all about
abstraction.
> > Are userspace solutions for this opensource today?
>
> No. But openPOWERLINK can be ported to userspace.
Sure.
> I would propose another solution. Just leave the high priority tasks
> in the kernel which directly deal with the Ethernet frames and
> implement all other modules in userspace.
So why not work completely ontop of raw sockets? What else do you need
in the kernel?
The only thing I can imagine is a fast packet switch that separates high
priority realtime packets from normal non-rt traffic in the network
stack. As far as I know, tglx has a patch for that.
Let's move the discussion to netdev.
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2009-03-20 8:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 18:32 The Linux Staging tree, what it is and is not Greg KH
2009-03-20 0:58 ` Robert Schwebel
2009-03-20 2:48 ` Greg KH
2009-03-20 8:34 ` Daniel Krüger
2009-03-20 8:46 ` Robert Schwebel [this message]
2009-03-20 17:25 ` Greg KH
2009-03-20 10:01 ` Alan Cox
2009-03-20 10:35 ` Robert Schwebel
2009-03-20 10:55 ` Alan Cox
2009-03-20 11:15 ` Robert Schwebel
2009-03-20 15:16 ` Daniel Krüger
2009-03-20 15:37 ` Alan Cox
2009-03-20 20:32 ` david
2009-03-23 9:03 ` Daniel Krüger
2009-03-23 9:16 ` Robert Schwebel
2009-03-20 4:26 ` Dave Airlie
2009-03-20 4:46 ` Greg KH
2009-03-20 16:05 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320084636.GP5367@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=daniel.krueger@systec-electronic.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mol@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=wsa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox