From: Greg KH <greg@kroah.com>
To: "Daniel Krüger" <daniel.krueger@systec-electronic.com>
Cc: Robert Schwebel <r.schwebel@pengutronix.de>,
linux-kernel@vger.kernel.org,
Michael Olbrich <mol@pengutronix.de>,
Wolfram Sang <wsa@pengutronix.de>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: The Linux Staging tree, what it is and is not.
Date: Fri, 20 Mar 2009 10:25:02 -0700 [thread overview]
Message-ID: <20090320172502.GA14647@kroah.com> (raw)
In-Reply-To: <49C35515.8050808@systec-electronic.com>
On Fri, Mar 20, 2009 at 09:34:29AM +0100, Daniel Krüger wrote:
> Greg KH schrieb:
>> On Fri, Mar 20, 2009 at 01:58:08AM +0100, Robert Schwebel wrote:
>>> Greg,
>>>
>>> On Wed, Mar 18, 2009 at 11:32:32AM -0700, Greg KH wrote:
>>>> If anyone has any questions that this summary doesn't answer, please let
>>>> me
>>>> know.
>>> Let me take this as an opportunity to discuss the epl (Ethernet
>>> Powerlink) driver in staging. Taken aside the eye-cancer thing while
>>> looking at the code (this could be fixed in the staging model), I
>>> suppose the whole design is questionable.
>> Sure it's questionable, and it's horrid code, but it is being used by
>> people and is the only public implementation of EPL on Linux that I can
>> find.
>
> BTW, the implementation does not follow the kernel style guide, because our
> company has its own code style guide. But what is that you don't like?
It's not an issue of "not liking" it, it just doesn't match the kernel
style guide.
I'll go make up a patch today to fix the layout and lots of the
structure issues of the code to match our rules, so that people can then
start working on the real functionality much easier.
thanks,
greg k-h
next prev parent reply other threads:[~2009-03-20 17:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 18:32 The Linux Staging tree, what it is and is not Greg KH
2009-03-20 0:58 ` Robert Schwebel
2009-03-20 2:48 ` Greg KH
2009-03-20 8:34 ` Daniel Krüger
2009-03-20 8:46 ` Robert Schwebel
2009-03-20 17:25 ` Greg KH [this message]
2009-03-20 10:01 ` Alan Cox
2009-03-20 10:35 ` Robert Schwebel
2009-03-20 10:55 ` Alan Cox
2009-03-20 11:15 ` Robert Schwebel
2009-03-20 15:16 ` Daniel Krüger
2009-03-20 15:37 ` Alan Cox
2009-03-20 20:32 ` david
2009-03-23 9:03 ` Daniel Krüger
2009-03-23 9:16 ` Robert Schwebel
2009-03-20 4:26 ` Dave Airlie
2009-03-20 4:46 ` Greg KH
2009-03-20 16:05 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320172502.GA14647@kroah.com \
--to=greg@kroah.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mol@pengutronix.de \
--cc=r.schwebel@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=wsa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox