From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alan Bartlett <ajb.stxsl@googlemail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] x86: fix IO APIC resource allocation error message
Date: Fri, 20 Mar 2009 20:12:41 +0100 [thread overview]
Message-ID: <200903202012.41344.bzolnier@gmail.com> (raw)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] x86: fix IO APIC resource allocation error message
Impact: fix incorrect error message
- IO APIC resource allocation error message contains one too many "be".
- Print the error message iff there are IO APICs in the system.
Cc: Alan Bartlett <ajb.stxsl@googlemail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
I've seen this error message for some time on my x86-32 laptop...
arch/x86/kernel/io_apic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/arch/x86/kernel/io_apic.c
===================================================================
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -4150,9 +4150,9 @@ static int __init ioapic_insert_resource
int i;
struct resource *r = ioapic_resources;
- if (!r) {
+ if (!r && nr_ioapics > 0) {
printk(KERN_ERR
- "IO APIC resources could be not be allocated.\n");
+ "IO APIC resources couldn't be allocated.\n");
return -1;
}
next reply other threads:[~2009-03-20 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 19:12 Bartlomiej Zolnierkiewicz [this message]
2009-03-20 19:23 ` [PATCH] x86: fix IO APIC resource allocation error message Ingo Molnar
2009-03-20 20:00 ` Bartlomiej Zolnierkiewicz
2009-03-20 20:03 ` [tip:x86/apic] " Bartlomiej Zolnierkiewicz
2009-03-20 19:33 ` [PATCH] " Cyrill Gorcunov
2009-03-20 20:02 ` Bartlomiej Zolnierkiewicz
2009-03-20 20:09 ` Cyrill Gorcunov
2009-03-20 20:27 ` Bartlomiej Zolnierkiewicz
2009-03-20 20:36 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903202012.41344.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=ajb.stxsl@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox