From: Andrew Morton <akpm@linux-foundation.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: forbid to re-enable I/O stat accounting
Date: Sat, 21 Mar 2009 03:03:09 -0700 [thread overview]
Message-ID: <20090321030309.f783ec8c.akpm@linux-foundation.org> (raw)
In-Reply-To: <200903201333.n2KDXONh023780@dhcp-0-152.brq.redhat.com>
Please fix your email headers - what I received was
From: Jerome Marchand <jmarchan@redhat.com>
To: unlisted-recipients:;;@imap1.linux-foundation.org (no To-header on input)
Cc: Jens Axboe <axboe@kernel.dk>
On Thu, 19 Mar 2009 11:36:50 +0100 Jerome Marchand <jmarchan@redhat.com> wrote:
> When we stop I/O stat accounting we stop to update the in-flight
> requests counter and we need this counter to be reliable for
> accounting I/O stats. Unfortunately updating in_flight field may
> affect performance. So, until we have a better solution, just forbid
> to re-enable I/O stat accounting after it has been disabled.
hm. Is it really so hard to just quiesce the device until all in-flight
requests have drained? freeze_bdev() might be a suitable starting point?
next prev parent reply other threads:[~2009-03-21 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 10:36 [PATCH] block: forbid to re-enable I/O stat accounting Jerome Marchand
2009-03-21 10:03 ` Andrew Morton [this message]
2009-03-21 11:14 ` Jens Axboe
2009-03-24 10:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090321030309.f783ec8c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox