public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] blktrace: report EBUSY correctly
Date: Sat, 21 Mar 2009 16:18:45 +0100	[thread overview]
Message-ID: <20090321151845.GA31890@elte.hu> (raw)
In-Reply-To: <20090320131017.GN30407@ghostprotocols.net>


* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Fri, Mar 20, 2009 at 09:49:08AM +0800, Li Zefan escreveu:
> > blk_trace_remove_queue() returns EINVAL if q->blk_trace == NULL,
> > but blk_trace_setup_queue() doesn't return EBUSY if q->blk_trace != NULL.
> > 
> >  # echo 0 > sdaX/trace/enable
> >  # echo 0 > sdaX/trace/enable
> >  bash: echo: write error: Invalid argument
> >  # echo 1 > sdaX/trace/enable
> >  # echo 1 > sdaX/trace/enable
> >  (should return EBUSY)
> > 
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Thanks for all the testing, its being really appreciated,
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>

thanks Arnaldo - i've added your acks to tip:tracing/blktrace.

Jens, are the changes fine with you too, can i merge them into 
tracing/core, for v2.6.30?

	Ingo

  reply	other threads:[~2009-03-21 15:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20  1:47 [PATCH 0/7] blktrace: various cleanups and fixes Li Zefan
2009-03-20  1:47 ` [PATCH 1/7] blktrace: fix possible memory leak Li Zefan
2009-03-20 10:25   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:53   ` [PATCH 1/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag Li Zefan
2009-03-20  8:47   ` Frederic Weisbecker
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:58   ` [PATCH 2/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 3/7] blktrace: remove blk_probe_mutex Li Zefan
2009-03-20  8:50   ` Frederic Weisbecker
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:03   ` [PATCH 3/7] " Arnaldo Carvalho de Melo
2009-03-22  6:04     ` Li Zefan
2009-03-22 15:09       ` Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:48 ` [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace Li Zefan
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:04   ` [PATCH 4/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:49 ` [PATCH 5/7] blktrace: report EBUSY correctly Li Zefan
2009-03-20 10:26   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:10   ` [PATCH 5/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18     ` Ingo Molnar [this message]
2009-03-21 15:19   ` [tip:tracing/blktrace] " Li Zefan
2009-03-20  1:49 ` [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() Li Zefan
2009-03-20  3:33   ` Li Zefan
2009-03-20 10:26     ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19     ` Li Zefan
2009-03-20 13:07   ` [PATCH 6/7] " Arnaldo Carvalho de Melo
2009-03-20  1:49 ` [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk Li Zefan
2009-03-20  2:34   ` Li Zefan
2009-03-20 10:26     ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19     ` Li Zefan
2009-03-20 13:08   ` [PATCH 7/7] " Arnaldo Carvalho de Melo
2009-03-20 10:20 ` [PATCH 0/7] blktrace: various cleanups and fixes Ingo Molnar
2009-03-20 11:09   ` Ingo Molnar
2009-03-23 14:48     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090321151845.GA31890@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox