From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 3/5] tracing/ftrace: check if debugfs is registered before creating files
Date: Mon, 23 Mar 2009 09:26:42 +0100 [thread overview]
Message-ID: <20090323082642.GC18837@elte.hu> (raw)
In-Reply-To: <1237759847-21025-3-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Impact: fix a crash with ftrace={nop,boot} parameter
>
> If the nop or initcall tracers are launched as boot tracers,
> they will attempt to create their option directory and files.
> But these tracers are registered very early and then assigned
> as "boot tracers" very early if asked to.
>
> Since they do this before debugfs has been registered (core initcall),
> a crash is triggered.
>
> Another early tracers could also come later. So we fix it by
> checking if debugfs is initialized before creating the root
> tracing directory.
>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> kernel/trace/trace.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
Note - i'll delay this patch pending Greg's Ack.
Ingo
next prev parent reply other threads:[~2009-03-23 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 22:10 [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 2/5] debugfs: function to know if debugfs is initialized Frederic Weisbecker
2009-03-23 8:18 ` Ingo Molnar
2009-03-23 14:41 ` Greg KH
2009-03-23 16:08 ` Ingo Molnar
2009-03-23 15:57 ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 3/5] tracing/ftrace: check if debugfs is registered before creating files Frederic Weisbecker
2009-03-23 8:26 ` Ingo Molnar [this message]
2009-03-23 15:57 ` [tip:tracing/ftrace] " Frederic Weisbecker
2009-03-23 19:18 ` [PATCH 3/5] " Steven Rostedt
2009-03-23 19:22 ` Ingo Molnar
2009-03-23 19:47 ` Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 4/5] tracing/events: don't use wake up for events Frederic Weisbecker
2009-03-23 8:30 ` [tip:tracing/filters] " Frederic Weisbecker
2009-03-23 19:21 ` Steven Rostedt
2009-03-23 19:33 ` Frederic Weisbecker
2009-03-22 22:10 ` [PATCH 5/5] tracing/ftrace: make nop using polling wait for events on pipe Frederic Weisbecker
2009-03-23 8:31 ` [tip:tracing/filters] tracing/ftrace: make nop-tracer use " Frederic Weisbecker
2009-03-22 22:12 ` [PATCH 1/5] tracing/events: make the filter files writable Frederic Weisbecker
2009-03-23 8:25 ` Ingo Molnar
2009-03-23 8:31 ` Frederic Weisbecker
2009-03-23 8:30 ` [tip:tracing/filters] " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323082642.GC18837@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox