From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "Tom Zanussi" <tzanussi@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing/filters: use list_for_each_entry_safe
Date: Mon, 23 Mar 2009 09:33:33 +0100 [thread overview]
Message-ID: <20090323083333.GD18837@elte.hu> (raw)
In-Reply-To: <49C748B0.20305@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> > - list_for_each_safe(entry, tmp, &call->fields) {
> > - field = list_entry(entry, struct ftrace_event_field, link);
> > + list_for_each_entry_safe(field, next, &call->fields, link) {
>
> Why we need _safe version ?
indeed the plain list_for_each_entry() variant would be fine, as the
list is only walked, not modified:
> > if (!strcmp(field->name, name))
> > return field;
> > }
(I've applied this patch already as it was a step forward - so
please enhance this in the next round of cleanups via a delta patch
- thanks!)
Ingo
next prev parent reply other threads:[~2009-03-23 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 8:26 [PATCH] tracing/filters: use list_for_each_entry_safe Tom Zanussi
2009-03-23 8:30 ` Li Zefan
2009-03-23 8:33 ` Ingo Molnar [this message]
2009-03-23 8:31 ` [tip:tracing/filters] " Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323083333.GD18837@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox