From: Rusty Russell <rusty@rustcorp.com.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Mathieu Desnoyers" <mathieu.desnoyers@polymtl.ca>,
"Ingo Molnar" <mingo@elte.hu>,
"Lai Jiangshan" <laijs@cn.fujitsu.com>,
"Jaswinder Singh Rajput" <jaswinder@kernel.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"x86 maintainers" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: oops in tracepoint_update_probe_range()
Date: Mon, 23 Mar 2009 15:48:14 +1030 [thread overview]
Message-ID: <200903231548.15631.rusty@rustcorp.com.au> (raw)
In-Reply-To: <alpine.DEB.2.00.0903191219260.16987@gandalf.stny.rr.com>
On Friday 20 March 2009 02:50:30 Steven Rostedt wrote:
> > Are we supposed to assume that module.c allows loading modules with
> > incompatible struct module at all ? That sounds like we would be trying
> > to fix up things broken by the module loader in the first place.
>
> Then it should be WARN_ON, no need to lock up a box hard, and give the
> user in X with no serial, no idea why the box just locked up.
In case anyone wonders, I don't care in general (though I won't protest if
anyone else wants to put checks in their code). You can crash in all kinds of exotic ways using the wrong modules. If you are a kernel dev, modversions will often save you (eg. struct module changing). If not, the kernel version string should change. Otherwise, someone's just messing with you.
Hope that helps,
Rusty.
next prev parent reply other threads:[~2009-03-23 5:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 16:23 [oops -tip] : x86 AMD 64 Jaswinder Singh Rajput
2009-03-18 16:35 ` oops in tracepoint_update_probe_range() (was: Re: [oops -tip] : x86 AMD 64) Ingo Molnar
2009-03-18 16:41 ` Frederic Weisbecker
2009-03-18 16:48 ` Jaswinder Singh Rajput
2009-03-18 16:54 ` Ingo Molnar
2009-03-18 16:56 ` Frederic Weisbecker
2009-03-18 17:27 ` Ingo Molnar
2009-03-18 17:33 ` Frederic Weisbecker
2009-03-18 17:33 ` [tip:tracing/ftrace] tracing: fix oops in tracepoint_update_probe_range() Jaswinder Singh Rajput
2009-03-18 17:38 ` Jaswinder Singh Rajput
2009-03-18 17:52 ` Jaswinder Singh Rajput
2009-03-18 17:51 ` Jaswinder Singh Rajput
2009-03-18 17:56 ` Jaswinder Singh Rajput
2009-03-18 18:00 ` Frederic Weisbecker
2009-03-18 18:12 ` Jaswinder Singh Rajput
2009-03-18 19:35 ` Frederic Weisbecker
2009-03-18 18:58 ` Ingo Molnar
2009-03-18 19:04 ` Jaswinder Singh Rajput
2009-03-18 17:57 ` Jaswinder Singh Rajput
2009-03-18 18:57 ` [tip:tracing/ftrace] tracepoints: dont update zero-sized tracepoint sections Ingo Molnar
2009-03-19 7:18 ` oops in tracepoint_update_probe_range() Lai Jiangshan
2009-03-19 7:46 ` Ingo Molnar
2009-03-19 9:41 ` Jaswinder Singh Rajput
2009-03-19 13:22 ` Mathieu Desnoyers
2009-03-19 13:34 ` Steven Rostedt
2009-03-19 14:03 ` Mathieu Desnoyers
2009-03-19 15:50 ` Ingo Molnar
2009-03-19 16:00 ` Mathieu Desnoyers
2009-03-19 16:20 ` Steven Rostedt
2009-03-23 5:18 ` Rusty Russell [this message]
2009-03-19 15:42 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903231548.15631.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=jaswinder@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox