From: Rusty Russell <rusty@rustcorp.com.au>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git-pull -tip] x86: cleanup patches 20090322
Date: Mon, 23 Mar 2009 18:45:04 +1030 [thread overview]
Message-ID: <200903231845.05394.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1237755176.5417.16.camel@ht.satnam>
On Monday 23 March 2009 07:22:56 Jaswinder Singh Rajput wrote:
> x86: e820.h fix various signedness issues in setup.c and e820.c
Wouldn't fixing the users be better than changing the header? Esp. since
it could well now cause similar warnings in userspace programs.
> struct e820map {
> - __u32 nr_map;
> + __s32 nr_map;
> struct e820entry map[E820_X_MAX];
> };
This number can't be negative!
Cheers,
Rusty.
next prev parent reply other threads:[~2009-03-23 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 20:52 [git-pull -tip] x86: cleanup patches 20090322 Jaswinder Singh Rajput
2009-03-23 8:15 ` Rusty Russell [this message]
2009-03-23 9:45 ` Jaswinder Singh Rajput
2009-03-23 10:35 ` Hannes Eder
2009-03-23 10:52 ` Jaswinder Singh Rajput
2009-03-23 21:10 ` Rusty Russell
2009-03-23 21:16 ` Sam Ravnborg
2009-03-23 10:07 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903231845.05394.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox