From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
penberg@cs.helsinki.fi, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/kmemtrace] kmemtrace: fix tracepoint declarations
Date: Tue, 24 Mar 2009 10:30:32 +0200 [thread overview]
Message-ID: <20090324083032.GA5383@localhost> (raw)
In-Reply-To: <tip-9d47aa18654e4344b1d20b14463addee676e9ea4@git.kernel.org>
On Tue, Mar 24, 2009 at 08:21:28AM +0000, Pekka Enberg wrote:
> Commit-ID: 9d47aa18654e4344b1d20b14463addee676e9ea4
> Gitweb: http://git.kernel.org/tip/9d47aa18654e4344b1d20b14463addee676e9ea4
> Author: Pekka Enberg <penberg@cs.helsinki.fi>
> AuthorDate: Tue, 24 Mar 2009 10:14:30 +0200
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Tue, 24 Mar 2009 09:19:52 +0100
>
> kmemtrace: fix tracepoint declarations
>
> Impact: build fix
>
> Use the new TP_PROTO and TP_ARGS to fix the build.
>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> LKML-Reference: <1237882470.25315.30.camel@penberg-laptop>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
>
> ---
> include/trace/kmemtrace.h | 24 ++++++++++++------------
> 1 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/include/trace/kmemtrace.h b/include/trace/kmemtrace.h
> index 9e28ae1..7514476 100644
> --- a/include/trace/kmemtrace.h
> +++ b/include/trace/kmemtrace.h
> @@ -15,41 +15,41 @@
> extern void kmemtrace_init(void);
>
> DECLARE_TRACE(kmalloc,
> - TPPROTO(unsigned long call_site,
> + TP_PROTO(unsigned long call_site,
> const void *ptr,
> size_t bytes_req,
> size_t bytes_alloc,
> gfp_t gfp_flags),
> - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags));
> + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags));
> DECLARE_TRACE(kmem_cache_alloc,
> - TPPROTO(unsigned long call_site,
> + TP_PROTO(unsigned long call_site,
> const void *ptr,
> size_t bytes_req,
> size_t bytes_alloc,
> gfp_t gfp_flags),
> - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags));
> + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags));
> DECLARE_TRACE(kmalloc_node,
> - TPPROTO(unsigned long call_site,
> + TP_PROTO(unsigned long call_site,
> const void *ptr,
> size_t bytes_req,
> size_t bytes_alloc,
> gfp_t gfp_flags,
> int node),
> - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node));
> + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node));
> DECLARE_TRACE(kmem_cache_alloc_node,
> - TPPROTO(unsigned long call_site,
> + TP_PROTO(unsigned long call_site,
> const void *ptr,
> size_t bytes_req,
> size_t bytes_alloc,
> gfp_t gfp_flags,
> int node),
> - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node));
> + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node));
> DECLARE_TRACE(kfree,
> - TPPROTO(unsigned long call_site, const void *ptr),
> - TPARGS(call_site, ptr));
> + TP_PROTO(unsigned long call_site, const void *ptr),
> + TP_ARGS(call_site, ptr));
> DECLARE_TRACE(kmem_cache_free,
> - TPPROTO(unsigned long call_site, const void *ptr),
> - TPARGS(call_site, ptr));
> + TP_PROTO(unsigned long call_site, const void *ptr),
> + TP_ARGS(call_site, ptr));
>
> #endif /* __KERNEL__ */
>
Thanks, I was clueless. I thought the problem was similar to the RCU
stuff.
Eduard
prev parent reply other threads:[~2009-03-24 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 8:14 [PATCH 1/2] kmemtrace: fix tracepoint declarations Pekka Enberg
2009-03-24 8:21 ` [tip:tracing/kmemtrace] " Pekka Enberg
2009-03-24 8:30 ` Eduard - Gabriel Munteanu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324083032.GA5383@localhost \
--to=eduard.munteanu@linux360.ro \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox