From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Ingo Molnar <mingo@elte.hu>
Cc: rostedt@goodmis.org, compudj@krystal.dyndns.org,
fweisbec@gmail.com, penberg@cs.helsinki.fi,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] kmemtrace: update usage of ring_buffer_lock_reserve()
Date: Tue, 24 Mar 2009 10:31:11 +0200 [thread overview]
Message-ID: <20090324083111.GB5383@localhost> (raw)
In-Reply-To: <20090323145556.GA21267@elte.hu>
On Mon, Mar 23, 2009 at 03:55:56PM +0100, Ingo Molnar wrote:
>
> * Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:
>
> > The ring buffer API has changed a bit and kmemtrace wasn't
> > compiling anymore. This fixes the issue and allows kmemtrace to
> > build.
> >
> > Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
>
> hm, kmemtrace was building and working fine in -tip:
>
> [root@aldebaran tracing]# head trace
> # tracer: kmemtrace
> #
> type_id 0 call_site 18446744071565600429 ptr 18446612139794190624
> type_id 0 call_site 18446744071565600392 ptr 18446612146227278976
> type_id 1 call_site 18446744071564535786 ptr 18446612146228083456
> type_id 0 call_site 18446744071565600392 ptr 18446612146240588256
> type_id 1 call_site 18446744071564535786 ptr 18446612146240893824
>
> the build error that is fixed by you here was introduced by your
> earlier 4/7 patch in this series:
>
> kmemtrace: use tracepoints
>
> So i've backmerged patch 7/7 into patch 4/7. Agreed?
>
> Ingo
My bad, thanks. Sounds fine to me.
Eduard
next prev parent reply other threads:[~2009-03-24 8:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 13:12 [PATCH 0/7] kmemtrace & tracing updates Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 1/7] RCU: don't include unnecessary headers, allow kmemtrace w/ tracepoints Eduard - Gabriel Munteanu
2009-03-23 15:18 ` [tip:tracing/kmemtrace] rcu: " Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 2/7] tracing: provide trace_seq_reserve() Eduard - Gabriel Munteanu
2009-03-23 15:18 ` [tip:tracing/kmemtrace] " Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 3/7] tracing: add missing 'extern' keywords to trace_output.h Eduard - Gabriel Munteanu
2009-03-23 15:18 ` [tip:tracing/kmemtrace] " Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 4/7] kmemtrace: use tracepoints Eduard - Gabriel Munteanu
2009-03-23 15:18 ` [tip:tracing/kmemtrace] " Eduard - Gabriel Munteanu
2009-04-03 10:36 ` [tip:tracing/kmemtrace-v2] " Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 5/7] kmemtrace: kmemtrace_alloc() must fill type_id Eduard - Gabriel Munteanu
2009-03-23 15:19 ` [tip:tracing/kmemtrace] " Eduard - Gabriel Munteanu
2009-04-03 10:36 ` [tip:tracing/kmemtrace-v2] " Eduard - Gabriel Munteanu
2009-03-23 13:12 ` [PATCH 6/7] kmemtrace: restore original tracing data binary format, improve ABI Eduard - Gabriel Munteanu
2009-03-23 15:06 ` Ingo Molnar
2009-03-23 15:19 ` [tip:tracing/kmemtrace] " Eduard - Gabriel Munteanu
2009-03-23 15:19 ` [tip:tracing/kmemtrace] kmemtrace: small cleanups Ingo Molnar
2009-04-03 10:37 ` [tip:tracing/kmemtrace-v2] kmemtrace: restore original tracing data binary format, improve ABI Eduard - Gabriel Munteanu
2009-04-03 10:37 ` [tip:tracing/kmemtrace-v2] kmemtrace: small cleanups Ingo Molnar
2009-03-23 13:12 ` [PATCH 7/7] kmemtrace: update usage of ring_buffer_lock_reserve() Eduard - Gabriel Munteanu
2009-03-23 14:55 ` Ingo Molnar
2009-03-24 8:31 ` Eduard - Gabriel Munteanu [this message]
2009-03-23 15:29 ` [PATCH 0/7] kmemtrace & tracing updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324083111.GB5383@localhost \
--to=eduard.munteanu@linux360.ro \
--cc=compudj@krystal.dyndns.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox