Re: [PATCH] kmemtrace: fix build breakage in befs

Ingo Molnar
2009-03-24T08:57:29Z

* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Tue, 2009-03-24 at 09:51 +0100, Ingo Molnar wrote:
> > there's another build problem as well, in squashfs, and in key.h:
> >
> > include/linux/key.h:128: error: field 'sem' has incomplete type
> > fs/squashfs/export.c:133: error: implicit declaration of function 'kmalloc'
> > fs/squashfs/export.c:143: error: implicit declaration of function 'kfree'
> >
> > And i suspect there's more as well. Is there really no unintrusive
> > way to solve this - or do you think the RCU change reduces the
> > include file spaghetti?
>
> I don't think there is and yes, I do think the RCU change cleans
> up things as well.

Okay. Note, you'll have to test tip:tracing/kmemtrace explicitly as
i had to exclude it from tip:master due to test failures. Will put
it back in once fixes arrive :)

Ingo