Re: [PATCH] kmemtrace: fix build breakage in befs

Alexey Dobriyan
2009-03-24T13:02:39Z

On Tue, Mar 24, 2009 at 10:53:46AM +0100, Ingo Molnar wrote:
> > -static inline char *alloc_secdata(void)
> > -{
> > - return (char *)get_zeroed_page(GFP_KERNEL);
> > -}
> > -
> > -static inline void free_secdata(void *secdata)
> > -{
> > - free_page((unsigned long)secdata);
> > -}
> > +#define alloc_secdata() (char *)get_zeroed_page(GFP_KERNEL)
> > +#define free_secdata() free_page((unsigned long) secdata)
>
> yep, that would be fine - but please add a comment about why they
> are macros and what would have to be done to fix it.

Nooo!

Stick it into security.h!

> (the real fix would be to separate fs.h into fs_types.h and
> fs_apis.h - like we did it with spinlock.h. Similarly with slab.h.)