public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <henrix@sapo.pt>
To: Gregory Haskins <ghaskins@novell.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 -tip] sched: Clean unused fields from struct rq
Date: Tue, 24 Mar 2009 18:22:05 +0000	[thread overview]
Message-ID: <20090324182205.GA3930@hades.domain.com> (raw)
In-Reply-To: <49C90366.2000905@novell.com>

Hi,

On Tue, Mar 24, 2009 at 11:59:34AM -0400, Gregory Haskins wrote:
> > How about moving schedstat to Documentation/sched/schedstat.c or so? 
> > It's small and trivial enough, and that way changes would go hand in 
> > hand with the app.
> >   
> Oh, I misunderstood.  The tool patch I was referencing is for my
> schedtop tool that is in a separate tree and written in C++.   In
> retrospect, you probably don't care about the relative state of my tool
> coincident with the kernel side change, then.  I agree that this other
> schedstat tool should probably be in-tree and patched at the same time
> as Luis' kernel patch.
> 
> FWIW: I have no problem with schedtop.cc going into the kernel as well
> if that is what you would like, but I figured I would be burned at the
> stake for suggestion such heresy as C++ in the tree ;)

I also agree that there will be issues adding schedtop to the kernel tree, for
two reasons: 1) it is written in C++ 2) it has dependencies on external
libraries (libboost).  So, unless the tool is re-written, I guess it will be
difficult have it accepted.  But that's just me saying this :-)

Now, to summarise and to check I understood everything correctly: I need to
resend my patch (the kernel patch), adding a reference to the URL where
schedtop can be obtained.  Is this correct?  Shall I use the URL to the git
repository or to the rt wiki?  Or both?

-- 
Luis Henriques

  reply	other threads:[~2009-03-24 18:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 22:51 [PATCH v3 -tip] sched: Clean unused fields from struct rq Luis Henriques
2009-03-18 22:54 ` Luis Henriques
2009-03-19  7:49   ` Ingo Molnar
2009-03-19 11:56     ` Gregory Haskins
2009-03-19 18:23       ` Luis Henriques
2009-03-19 18:51         ` Gregory Haskins
2009-03-19 18:43   ` Gregory Haskins
2009-03-23 17:52 ` Luis Henriques
2009-03-24 14:04   ` Ingo Molnar
2009-03-24 15:22     ` Gregory Haskins
2009-03-24 15:41       ` Ingo Molnar
2009-03-24 15:59         ` Gregory Haskins
2009-03-24 18:22           ` Luis Henriques [this message]
2009-03-24 21:04           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324182205.GA3930@hades.domain.com \
    --to=henrix@sapo.pt \
    --cc=ghaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox