From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
ltt-dev@lists.casi.polymtl.ca,
Frederic Weisbecker <fweisbec@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Masami Hiramatsu <mhiramat@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Hideo AOKI <haoki@redhat.com>,
Takashi Nishiie <t-nishiie@np.css.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [patch 6/9] LTTng instrumentation - timer
Date: Tue, 24 Mar 2009 21:47:19 +0100 [thread overview]
Message-ID: <20090324204719.GA24320@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0903242011520.29264@localhost.localdomain>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Tue, 24 Mar 2009, Ingo Molnar wrote:
> > the init methods are missing from your patch entirely - and the rest
> > is partially incomplete as well.
> >
> > Instrumentation of the del_timer() variants is missing. For a
> > complete lifetime analysis of timers this cannot be left out.
>
> Look at the debugobjects hooks. They cover the complete timer life
> time already.
>
> Piggypacking tracepoints on those would simplify maintenance and
> reduce the number of extra lines in the code.
makes sense. They dont cover itimers nor hrtimers though.
Ingo
next prev parent reply other threads:[~2009-03-24 20:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 15:56 [patch 0/9] LTTng core kernel instrumentation Mathieu Desnoyers
2009-03-24 15:56 ` [patch 1/9] IRQ handle prepare for instrumentation Mathieu Desnoyers
2009-03-24 15:56 ` [patch 2/9] LTTng instrumentation - irq Mathieu Desnoyers
2009-03-24 17:33 ` Jason Baron
2009-03-24 17:50 ` Ingo Molnar
2009-03-24 17:57 ` Jason Baron
2009-03-24 19:12 ` Ingo Molnar
2009-03-24 20:11 ` Mathieu Desnoyers
2009-03-24 20:51 ` Ingo Molnar
2009-03-25 8:47 ` Ingo Molnar
2009-03-25 18:30 ` Mathieu Desnoyers
2009-03-25 2:00 ` Steven Rostedt
2009-03-26 18:27 ` Mathieu Desnoyers
2009-03-27 22:53 ` Steven Rostedt
2009-04-02 2:42 ` Mathieu Desnoyers
2009-03-25 2:09 ` Steven Rostedt
2009-03-26 18:28 ` Mathieu Desnoyers
2009-03-27 19:18 ` Jason Baron
2009-03-24 19:14 ` Ingo Molnar
2009-03-27 22:12 ` Thomas Gleixner
2009-03-24 15:56 ` [patch 3/9] LTTng instrumentation tasklets Mathieu Desnoyers
2009-03-24 17:56 ` Ingo Molnar
2009-03-25 13:52 ` Chetan.Loke
2009-03-25 14:17 ` Peter Zijlstra
2009-03-25 17:37 ` Chetan.Loke
2009-03-25 17:52 ` Steven Rostedt
2009-03-24 15:56 ` [patch 4/9] LTTng instrumentation softirq Mathieu Desnoyers
2009-03-24 18:01 ` Ingo Molnar
2009-03-24 15:56 ` [patch 5/9] LTTng instrumentation scheduler fix task migration Mathieu Desnoyers
2009-03-24 17:53 ` Ingo Molnar
2009-03-24 15:56 ` [patch 6/9] LTTng instrumentation - timer Mathieu Desnoyers
2009-03-24 18:21 ` Ingo Molnar
2009-03-24 19:14 ` Thomas Gleixner
2009-03-24 20:47 ` Ingo Molnar [this message]
2009-03-27 22:05 ` Thomas Gleixner
2009-03-24 15:56 ` [patch 7/9] LTTng instrumentation - kernel Mathieu Desnoyers
2009-03-24 18:33 ` Ingo Molnar
2009-03-25 1:13 ` Rusty Russell
2009-03-25 8:40 ` Ingo Molnar
2009-03-25 13:06 ` Frederic Weisbecker
2009-03-24 15:56 ` [patch 8/9] LTTng instrumentation - filemap Mathieu Desnoyers
2009-03-24 18:39 ` Ingo Molnar
2009-03-24 15:56 ` [patch 9/9] LTTng instrumentation - swap Mathieu Desnoyers
2009-03-24 18:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324204719.GA24320@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eduard.munteanu@linux360.ro \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=haoki@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@lists.casi.polymtl.ca \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=t-nishiie@np.css.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox