Re: [PATCH 01/30] disallow SERIAL_8250_PNP with SERIAL_8250_CONSOLE

Matthew Garrett
2009-03-24T21:34:43Z

On Tue, Mar 24, 2009 at 09:26:53PM +0000, Alan Cox wrote:
> On Tue, 24 Mar 2009 20:59:47 +0000
> Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> > On Tue, Mar 24, 2009 at 03:22:03PM +0000, Alan Cox wrote:
> > > > This patch looks very controversial from my POV. Now distro people must decide
> > > > what to enable SERIAL_8250_PNP or SERIAL_8250_CONSOLE. And no matter what you
> > >
> > > They do already, otherwise your machine crashes at boot.
> >
> > We don't. The effect of this patch would be to silently disable 8250_PNP
> > (since we don't build with CONFIG_EMBEDDED) and cause a surprising
> > reduction in hardware support. How long has this been broken for?
>
> Since the conversion to drivers/serial - so years.

So everyone using serial console with 8250_PNP enabled gets a crash on
boot, and has done for years? Really?

--
Matthew Garrett | mjg59@srcf.ucam.org