Re: [PATCH 01/30] disallow SERIAL_8250_PNP with SERIAL_8250_CONSOLE

Andrey Panin
2009-03-24T15:10:52Z

On 083, 03 24, 2009 at 02:01:52PM +0000, Alan Cox wrote:
> From: Clark Williams <williams@redhat.com>
>
> There are known (but hard to fix issues) with using SERIAL_8250_PNP with
> SERIAL_8250_CONSOLE. This patch just sidesteps that by not allowing PNP
> when CONSOLE is selected.

This patch looks very controversial from my POV. Now distro people must decide
what to enable SERIAL_8250_PNP or SERIAL_8250_CONSOLE. And no matter what you
choose you'll get a regression, non-working serial console vs broken detection of
perfectly working hardware like additional serial ports on industrial computers,
notebook touchpads and finally old and dusty ISA PnP modems.

How widespread are these "known but hard to fix issues", to justify such drastic
change ?

> Signed-off-by: Clark Williams <williams@redhat.com>
> Signed-off-by: Alan Cox <number6@the-village.bc.nu>
> ---
>
> drivers/serial/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 7d7f576..451b64f 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -91,7 +91,7 @@ config SERIAL_8250_PCI
>
> config SERIAL_8250_PNP
> tristate "8250/16550 PNP device support" if EMBEDDED
> - depends on SERIAL_8250 && PNP
> + depends on SERIAL_8250 && PNP && ! SERIAL_8250_CONSOLE
> default SERIAL_8250
> help
> This builds standard PNP serial support. You may be able to
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>