Re: [PATCH 5/5][RFC] function-graph: add option to calculate graph time or not

Ingo Molnar
2009-03-25T10:12:29Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -104,9 +105,6 @@ ftrace_pop_return_trace(struct ftrace_graph_ret *trace, unsigned long *ret)
> trace->calltime = current->ret_stack[index].calltime;
> trace->overrun = atomic_read(&current->trace_overrun);
> trace->depth = index;
> - barrier();
> - current->curr_ret_stack--;
> -
> }
>
> /*
> @@ -121,6 +119,8 @@ unsigned long ftrace_return_to_handler(void)
> ftrace_pop_return_trace(&trace, &ret);
> trace.rettime = trace_clock_local();
> ftrace_graph_return(&trace);
> + barrier();
> + current->curr_ret_stack--;

this will modify the regular graph tracer too. No discussion of this
change in the changelog - is it a fix?

Ingo