From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Frederic Weisbecker" <fweisbec@gmail.com>,
"Tim Bird" <tim.bird@am.sony.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
"linux kernel" <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Abhishek Sagar" <sagar.abhishek@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: Anyone working on ftrace function graph support on ARM?
Date: Wed, 25 Mar 2009 08:36:02 +0000 [thread overview]
Message-ID: <20090325083602.GE4697@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090324221439.GE29509@elte.hu>
On Tue, Mar 24, 2009 at 11:14:39PM +0100, Ingo Molnar wrote:
> So the rule is: mcount must not destroy _any_ register state.
> (beyond flags)
As has already been discussed on the ARM lists, we have a problem with
using mcount along with EABI, or OABI without frame pointers. We can
not avoid destroying 'lr' - the return address for the function.
OABI works around this by assuming that the parent function saved a
stack frame, which means it's at a known offset from the frame pointer
(provided frame pointers are enabled.) mcount reloads 'lr' before
returning:
ENTRY(mcount)
stmdb sp!, {r0-r3, lr}
mov r0, lr
sub r0, r0, #MCOUNT_INSN_SIZE
.globl mcount_call
mcount_call:
bl ftrace_stub
ldr lr, [fp, #-4] @ restore lr
ldmia sp!, {r0-r3, pc}
So I think if Tim is expecting to be able to use this feature on EABI
kernels, he's going to struggle.
next prev parent reply other threads:[~2009-03-25 8:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 19:38 Anyone working on ftrace function graph support on ARM? Tim Bird
2009-03-24 20:25 ` Ingo Molnar
2009-03-24 20:48 ` Tim Bird
2009-03-24 20:38 ` Uwe Kleine-König
2009-03-24 21:36 ` Frederic Weisbecker
2009-03-24 21:40 ` Tim Bird
2009-03-24 21:48 ` Ingo Molnar
2009-03-24 21:57 ` Frederic Weisbecker
2009-03-24 22:14 ` Ingo Molnar
2009-03-24 22:54 ` Frederic Weisbecker
2009-03-25 8:36 ` Russell King - ARM Linux [this message]
2009-03-25 16:00 ` Steven Rostedt
2009-03-25 17:13 ` Frederic Weisbecker
2009-03-25 20:27 ` [PATCH][GIT PULL] x86, function-graph: only save return values on x86_64 Steven Rostedt
2009-03-25 20:45 ` Jaswinder Singh Rajput
2009-03-25 21:26 ` Steven Rostedt
2009-04-08 16:09 ` Ingo Molnar
2009-04-08 16:37 ` Steven Rostedt
2009-04-08 16:41 ` Ingo Molnar
2009-04-08 17:40 ` Frederic Weisbecker
2009-03-24 22:29 ` Anyone working on ftrace function graph support on ARM? Abhishek Sagar
2009-03-24 22:48 ` Frederic Weisbecker
2009-03-25 8:42 ` Russell King - ARM Linux
2009-03-25 8:54 ` Ingo Molnar
2009-03-25 9:57 ` Russell King - ARM Linux
2009-03-25 10:45 ` Uwe Kleine-König
2009-03-25 11:21 ` Russell King - ARM Linux
2009-03-25 12:09 ` Uwe Kleine-König
2009-03-25 16:41 ` Tim Bird
2009-03-25 11:41 ` Frederic Weisbecker
2009-03-25 16:34 ` Tim Bird
2009-03-25 17:05 ` Uwe Kleine-König
2009-03-25 17:17 ` Russell King - ARM Linux
2009-03-25 18:37 ` Tim Bird
2009-03-25 18:41 ` Steven Rostedt
2009-03-27 12:58 ` Catalin Marinas
2009-04-09 15:29 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325083602.GE4697@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sagar.abhishek@gmail.com \
--cc=tim.bird@am.sony.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox