From: Ingo Molnar <mingo@elte.hu>
To: Frank Seidel <fseidel@kernel.org>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, Masami Hiramatsu <mhiramat@redhat.com>,
Arjan van de Ven <arjan@infradead.org>,
Jim Keniston <jkenisto@us.ibm.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, Frank Seidel <frank@f-seidel.de>
Subject: Re: [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c
Date: Wed, 25 Mar 2009 13:38:12 +0100 [thread overview]
Message-ID: <20090325123812.GA30755@elte.hu> (raw)
In-Reply-To: <49CA24B6.103@kernel.org>
* Frank Seidel <fseidel@kernel.org> wrote:
> From: Frank Seidel <frank@f-seidel.de>
>
> Remove warning (makes integer from pointer without a cast)
> from build messages.
>
> Signed-off-by: Frank Seidel <frank@f-seidel.de>
> ---
> arch/x86/kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_op
> kprobe_opcode_t opcode;
> kprobe_opcode_t *orig_opcodes = opcodes;
>
> - if (search_exception_tables(opcodes))
> + if (search_exception_tables((unsigned long)opcodes))
> return 0; /* Page fault may occur on this address. */
fixed in the x86 tree:
http://people.redhat.com/mingo/tip.git/README
a couple of days ago. (see the commit below)
Ingo
---------->
>From cde5edbda8ba7d600154ce4171125a48e4d2a21b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
Date: Wed, 18 Mar 2009 17:37:45 +0530
Subject: [PATCH] x86: kprobes.c fix compilation warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
arch/x86/kernel/kprobes.c:196: warning: passing argument 1 of ‘search_exception_tables’ makes integer from pointer without a cast
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference:<49BED952.2050809@redhat.com>
LKML-Reference: <1237378065.13488.2.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/kprobes.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 4558dd3..55b9461 100644
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -193,7 +193,7 @@ static int __kprobes can_boost(kprobe_opcode_t *opcodes)
kprobe_opcode_t opcode;
kprobe_opcode_t *orig_opcodes = opcodes;
- if (search_exception_tables(opcodes))
+ if (search_exception_tables((unsigned long)opcodes))
return 0; /* Page fault may occur on this address. */
retry:
next prev parent reply other threads:[~2009-03-25 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 12:33 [PATCH] trivial: remove warning from arch/x86/kernel/kprobes.c Frank Seidel
2009-03-25 12:38 ` Ingo Molnar [this message]
2009-03-25 12:43 ` Frank Seidel
2009-03-25 13:15 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325123812.GA30755@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=frank@f-seidel.de \
--cc=fseidel@kernel.org \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox