Re: [PATCH UPDATED] percpu: use dynamic percpu allocator as the default percpu allocator

Ingo Molnar
2009-04-14T14:06:43Z

* Christoph Lameter <cl@linux.com> wrote:

> On Wed, 8 Apr 2009, Ingo Molnar wrote:
>
> > Dude, this is a new facility freshly modernized and freshly made
> > usable. What did you expect, for a thousand usecases pop up in the
> > kernel overnight? _None_ of this code is "common" today per se. (the
> > networking folks are working on making it more and more common
> > though)
>
> ?? kfree(NULL) has been allowed for years. None of this is new.

[ This reply if yours is completely inapposite. It does not fit into
the logical stream of arguments at all. Of course kfree(NULL) has
been allowed for years. Did i claim otherwise? I dont think you
understand my arguments - and i get the impression that you dont
even _try_ to understand them. ]

The thing is, i spent well in excess of an hour analyzing your
patch, counting cachelines, looking at effects and interactions,
thinking about the various implications. I came up with a good deal
of factoids, a handful of suggestions and a few summary paragraphs:

http://marc.info/?l=linux-kernel&m=123862536011780&w=2

A proper reply to that work would be one of several responses:

1) to ignore it. (you can always do that, you dont have to react
to everything on lkml - especially if you think it's bull.)

2) disagree with the factoids - preferably in a specific way.

3) agree with the factoids and disagree with my opinion.

4) agree with it all.

You did neither of these: you never replied to my detailed analysis,
you only replied to my followup summary - disagreeing with my
opinion based not on a fair deconstruction of my factoids but on a
mere repetition of your arguments.

Furthermore, you also tried to 'win' this argument by increasing the
volume of shouting, by injecting unprovoked insults and by using a
patronizing and irritated tone.

You might be completely right in the end technically (i fully submit
that the discussion is open-ended), but this kind of generic
handwaving and your asocial behavior in this thread does not really
do your technical arguments any service. It can only really end in
me starting to ignore you.

Ingo