Re: [GIT RFC] percpu: use dynamic percpu allocator as the default percpu allocator

Rusty Russell
2009-04-11T01:38:32Z

On Thu, 9 Apr 2009 09:23:25 pm Tejun Heo wrote:
> It's generally a good idea to use uniquely
> distinguisible identifier for static symbols anyway to help debugging.

Sorry, I can't let this statement stand. It's completely wrong: use the
shortest clear name, always.

> If this limitation is acceptable, I think we should also add the dup
> build failure thing to the generic definition too tho so that such
> cases can be discovered before they hit alpha and s390 later.
>
> Any objections?

Yes. If we decide that static per-cpu is unsupportable, let's not hide the
damn thing. We just make it give a compile warning if we can, patch out the
current cases, and make checkpatch.pl warn on new ones.

Don't silently override "static". Don't come up with stupid justifications.
Accept with open-eyes that it's evil, just a lesser evil.

Thanks,
Rusty.