Re: [PATCH v2] net: Add support for the OpenCores 10/100 Mbps Ethernet MAC.

David Miller
2009-03-26T00:18:39Z

From: Thierry Reding <thierry.reding@avionic-design.de>
Date: Wed, 25 Mar 2009 15:57:07 +0100

> This patch adds a platform device driver that supports the OpenCores 10/100
> Mbps Ethernet MAC.
>
> The driver expects three resources: one IORESOURCE_MEM resource defines the
> memory region for the core's memory-mapped registers while a second
> IORESOURCE_MEM resource defines the network packet buffer space. The third
> resource, of type IORESOURCE_IRQ, associates an interrupt with the driver.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> Acked-by: Florian Fainelli <florian@openwrt.org>

I have some issues with the CONFIG_MII tests.

It seems better to just "select MII" in the Kconfig entry for this
driver. So could you please do that instead? I don't see how this
chip could possible work and obtain a link without the MII interface
being setup properly.

Besides, the ifdefs are ugly :-)

Other than this, the driver looks great. Please fix up this MII
issue and I will add the driver to my tree.

Thanks!