From: Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org,
"Paul E. McKenney" <paulmck@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
penberg@cs.helsinki.fi, eduard.munteanu@linux360.ro,
tglx@linutronix.de
Subject: Re: [tip:tracing/kmemtrace] rcutree: fix rcu_tree_trace.c data structure dependencies
Date: Wed, 25 Mar 2009 17:11:47 +0100 [thread overview]
Message-ID: <20090325161147.GA18738@elte.hu> (raw)
In-Reply-To: <tip-5d957021d326fbfdc1d7a4f11a3da1f6f82d6a36@git.kernel.org>
* Ingo Molnar <mingo@elte.hu> wrote:
> Commit-ID: 5d957021d326fbfdc1d7a4f11a3da1f6f82d6a36
> Gitweb: http://git.kernel.org/tip/5d957021d326fbfdc1d7a4f11a3da1f6f82d6a36
> Author: Ingo Molnar <mingo@elte.hu>
> AuthorDate: Wed, 25 Mar 2009 16:42:24 +0100
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Wed, 25 Mar 2009 16:42:24 +0100
>
> rcutree: fix rcu_tree_trace.c data structure dependencies
>
> Impact: build fix
>
> We removed rcutree internals from the public rcutree.h file - but
> kernel/rcutree_trace.c depends on them.
>
> Introduce kernel/rcutree.h for internal definitions. (Probably all
> the other data types from include/linux/rcutree.h could be
> moved here too - except rcu_data.)
Paul ... what do you think? This is just an interim measure to get
the build going - i think we could do more cleanups here perhaps, if
you agree.
I think many of the data definitions (and the resulting include file
dependencies) in include/linux/rcu*.h could move into kernel/rcu*.h
and be privatized that way. 'struct rcu_state' would be an example.
Agreed?
Ingo
next prev parent reply other threads:[~2009-03-25 16:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1237898630.25315.83.camel@penberg-laptop>
2009-03-25 15:18 ` [tip:tracing/kmemtrace] RCU, kmemtrace: fix linux/rcutree.h and linux/rcuclassic.h dependencies Ingo Molnar
2009-03-25 15:33 ` [tip:tracing/kmemtrace] fs, kmemtrace: fix linux/fdtable.h header file dependencies Ingo Molnar
2009-03-25 15:51 ` [tip:tracing/kmemtrace] rcutree: fix rcu_tree_trace.c data structure dependencies Ingo Molnar
2009-03-25 16:11 ` Ingo Molnar [this message]
2009-03-25 16:52 ` Paul E. McKenney
2009-03-25 16:57 ` Ingo Molnar
2009-03-26 3:34 ` Paul E. McKenney
2009-03-25 15:54 ` [tip:tracing/kmemtrace] fs, kmemtrace: fix fs.h's PAGE_SIZE dependency Ingo Molnar
2009-03-25 16:06 ` [tip:tracing/kmemtrace] rcutree: fix rcupreempt.c data structure dependencies Ingo Molnar
2009-03-25 16:51 ` [tip:tracing/kmemtrace] fs.h: uninline simple_transaction_set() Ingo Molnar
2009-03-25 17:01 ` Ingo Molnar
2009-03-26 15:48 ` Al Viro
2009-03-27 9:26 ` Ingo Molnar
2009-03-25 17:30 ` Ingo Molnar
2009-03-28 11:45 ` Ingo Molnar
2009-04-03 10:34 ` [tip:tracing/kmemtrace-v2] kmemtrace, fs: " Ingo Molnar
2009-04-03 10:34 ` [tip:tracing/kmemtrace-v2] kmemtrace, fs: fix linux/fdtable.h header file dependencies Ingo Molnar
2009-04-03 10:35 ` [tip:tracing/kmemtrace-v2] kmemtrace, rcu: fix linux/rcutree.h and linux/rcuclassic.h dependencies Ingo Molnar
2009-04-03 10:36 ` [tip:tracing/kmemtrace-v2] kmemtrace, rcu: fix rcu_tree_trace.c data structure dependencies Ingo Molnar
2009-04-03 10:36 ` [tip:tracing/kmemtrace-v2] kmemtrace, rcu: fix rcupreempt.c " Ingo Molnar
2009-04-03 10:36 ` [tip:tracing/kmemtrace-v2] kmemtrace, rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325161147.GA18738@elte.hu \
--to=mingo@elte.hu \
--cc=eduard.munteanu@linux360.ro \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@us.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox