Re: [PATCH 2.4] CAP_FS_MASK: add CAP_LINUX_IMMUTABLE and CAP_MKNOD

Serge E. Hallyn
2009-03-26T13:28:29Z

Quoting Willy Tarreau (w@1wt.eu):
> Hello,
>
> On Wed, Mar 25, 2009 at 12:39:54PM -0500, Serge E. Hallyn wrote:
> > When POSIX capabilities were introduced during the 2.1 Linux
> > cycle, the fs mask, which represents the capabilities which having
> > fsuid==0 is supposed to grant, did not include CAP_MKNOD and
> > CAP_LINUX_IMMUTABLE. However, before capabilities the privilege
> > to call these did in fact depend upon fsuid==0.
> >
> > This patch introduces those capabilities into the fsmask,
> > restoring the old behavior.
> >
> > See the thread starting at http://lkml.org/lkml/2009/3/11/157 for
> > reference.
>
> Thanks to Igor and you for fixing this. The impact did not appear
> obvious to me at first, to be honnest! I'm queuing the patch for
> next release.
>
> BTW, I've noticed your other patch for 2.2.26, but it's not worth
> wasting time on it, as 2.2 has remained unmaintained for years now
> and people are really discouraged from using it as many holes have
> never been fixed there.
>
> Cheers,
> Willy

Sounds good to me.

thanks,
-serge