From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Credit for vsprintk work
Date: Wed, 25 Mar 2009 20:24:43 +0100 [thread overview]
Message-ID: <20090325192439.GG5932@nowhere> (raw)
In-Reply-To: <alpine.DEB.2.00.0903250949420.5675@gandalf.stny.rr.com>
On Wed, Mar 25, 2009 at 09:58:52AM -0400, Steven Rostedt wrote:
>
> Frederic,
>
> $ git blame lib/vsprintf.c |grep 'Frederic Weisbecker' | wc -l
> 542
>
> You did a hell of a lot of work on vsprintf.c, and you are still too
> modest to put in a copyright at the top.
>
> I know some people think that git is good enough for ownership. But
> really, the amount of changes that you did in vsprintf.c deserves a bit of
> credit in the source file.
>
> Is everyone OK if a copyright goes at the top of this file giving credit
> to Frederic? If for anything else, it will facilitate people to find who
> broke it if it breaks ;-)
>
> I think Frederic should send one more patch to add his copyright. That is,
> of course, if Frederic wants too.
>
> Note, Frederic did not ask me to post this. In fact, this is the first
> time he's seen this complaint. I'm posting this because I was showing this
> code to some students at a University and when I wanted to point out
> who wrote it, I was surprised that Frederic's name was not mentioned.
> I was looking at the code via LXR so git was not helpful here.
>
> -- Steve
>
:-)
Ok, so if nobody is opposite to, I will send a patch for that.
Lai, no problem with me adding your copyright too?
Thanks!
next prev parent reply other threads:[~2009-03-25 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:58 Credit for vsprintk work Steven Rostedt
2009-03-25 14:18 ` Steven Rostedt
2009-03-25 15:27 ` Ingo Molnar
2009-03-25 16:59 ` Linus Torvalds
2009-03-25 17:17 ` Steven Rostedt
2009-03-25 19:24 ` Frederic Weisbecker [this message]
2009-03-27 2:41 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325192439.GG5932@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox