public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: Kill warning: label 'free_init' defined but not used
Date: Thu, 26 Mar 2009 09:22:57 +1030	[thread overview]
Message-ID: <200903260922.57393.rusty@rustcorp.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0903252041190.14101@anakin>

On Thursday 26 March 2009 06:13:06 Geert Uytterhoeven wrote:
> On m68k (which doesn't do SMP), I get:
> 
> | kernel/module.c:2291: warning: label 'free_init' defined but not used
> 
> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
> ("module: fix refptr allocation and release order").
> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Thanks, already in my tree.  I'll get off my ass and push to Linus in next
couple of days.

Thanks!
Rusty.

      parent reply	other threads:[~2009-03-25 22:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 19:43 [PATCH] module: Kill warning: label 'free_init' defined but not used Geert Uytterhoeven
2009-03-25 19:54 ` Jaswinder Singh Rajput
2009-03-25 20:05   ` Geert Uytterhoeven
2009-03-25 20:22     ` Jaswinder Singh Rajput
2009-03-25 22:52 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903260922.57393.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox