[PATCH] module: Kill warning: label 'free_init' defined but not used

[PATCH] module: Kill warning: label 'free_init' defined but not used

[Geert Uytterhoeven]

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index 1196f5d..df00a1b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2288,8 +2288,8 @@ static noinline struct module *load_module(void __user *umod,
 	ftrace_release(mod->module_core, mod->core_size);
  free_unload:
 	module_unload_free(mod);
- free_init:
 #if defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP)
+ free_init:
 	percpu_modfree(mod->refptr);
 #endif
 	module_free(mod, mod->module_init);
-- 
1.6.2


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] module: Kill warning: label 'free_init' defined but not used

[Jaswinder Singh Rajput]

On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote:
> On m68k (which doesn't do SMP), I get:
> 
> | kernel/module.c:2291: warning: label 'free_init' defined but not used
> 
> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
> ("module: fix refptr allocation and release order").
> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---

AFAIK, it is already fixed in -tip:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7

--
JSR

Re: [PATCH] module: Kill warning: label 'free_init' defined but not used

[Geert Uytterhoeven]

On Wed, Mar 25, 2009 at 20:54, Jaswinder Singh Rajput
<jaswinder@kernel.org> wrote:
> On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote:
>> On m68k (which doesn't do SMP), I get:
>>
>> | kernel/module.c:2291: warning: label 'free_init' defined but not used
>>
>> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
>> ("module: fix refptr allocation and release order").
>> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>
> AFAIK, it is already fixed in -tip:
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7

Interesting, as I noticed the problem in today's linux-next.
http://kisskb.ellerman.id.au/kisskb/buildresult/271602/
Or am I caught again by fake warnings from the bisection process?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] module: Kill warning: label 'free_init' defined but not used

[Jaswinder Singh Rajput]

On Wed, 2009-03-25 at 21:05 +0100, Geert Uytterhoeven wrote:
> On Wed, Mar 25, 2009 at 20:54, Jaswinder Singh Rajput
> <jaswinder@kernel.org> wrote:
> > On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote:
> >> On m68k (which doesn't do SMP), I get:
> >>
> >> | kernel/module.c:2291: warning: label 'free_init' defined but not used
> >>
> >> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
> >> ("module: fix refptr allocation and release order").
> >> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> ---
> >
> > AFAIK, it is already fixed in -tip:
> > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7
> 
> Interesting, as I noticed the problem in today's linux-next.
> http://kisskb.ellerman.id.au/kisskb/buildresult/271602/
> Or am I caught again by fake warnings from the bisection process?
> 

Yes, you are right linux-next is still having this problem.

You are the third guy who came with this fix.

Two of them are already applied in -tip and Rusty's tree:

----------->
On Wed, 2009-03-25 at 11:35 +1030, Rusty Russell wrote: 
> On Wednesday 25 March 2009 02:37:19 Américo Wang wrote:
> > 
> > Label 'free_init' is only used when defined(CONFIG_MODULE_UNLOAD) &&
> > defined(CONFIG_SMP), so move it inside to shut up gcc.
> 
> Thanks, applied!
> Rusty.
<-----------

May be you can also try linux-next tree ;-)

--
JSR

Re: [PATCH] module: Kill warning: label 'free_init' defined but not used

[Rusty Russell]

On Thursday 26 March 2009 06:13:06 Geert Uytterhoeven wrote:
> On m68k (which doesn't do SMP), I get:
> 
> | kernel/module.c:2291: warning: label 'free_init' defined but not used
> 
> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
> ("module: fix refptr allocation and release order").
> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Thanks, already in my tree.  I'll get off my ass and push to Linus in next
couple of days.

Thanks!
Rusty.