From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
Arjan van de Ven <arjan@infradead.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [RFC][PATCH 2/3] perf_counter: executable mmap() information
Date: Thu, 26 Mar 2009 11:00:58 +0100 [thread overview]
Message-ID: <20090326100058.GD19826@elte.hu> (raw)
In-Reply-To: <18891.6159.109191.255560@drongo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> Peter Zijlstra writes:
>
> > --- linux-2.6.orig/include/linux/perf_counter.h
> > +++ linux-2.6/include/linux/perf_counter.h
> > @@ -137,7 +137,9 @@ struct perf_counter_hw_event {
> > exclude_kernel : 1, /* ditto kernel */
> > exclude_hv : 1, /* ditto hypervisor */
> > exclude_idle : 1, /* don't count when idle */
> > - include_tid : 1, /* include the tid */
> > + include_tid : 1, /* include the tid */
> > + mmap : 1, /* include mmap data */
> > + munmap : 1, /* include munmap data */
> >
> > __reserved_1 : 54;
>
> Nit: need to adjust the size of __reserved_1 here. Or maybe just
> get rid of it?
it's nice to have a constant reminder about how many bits there are
left.
Ingo
next prev parent reply other threads:[~2009-03-26 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 21:04 [RFC][PATCH 0/3] more perf_counter stuff Peter Zijlstra
2009-03-25 21:04 ` [RFC][PATCH 1/3] perf_counter: event overlow handling Peter Zijlstra
2009-03-25 21:04 ` [RFC][PATCH 2/3] perf_counter: executable mmap() information Peter Zijlstra
2009-03-26 5:52 ` Paul Mackerras
2009-03-26 10:00 ` Ingo Molnar [this message]
2009-03-26 10:57 ` Paul Mackerras
2009-03-26 11:13 ` Paul Mackerras
2009-03-25 21:04 ` [RFC][PATCH 3/3] perf_counter: kerneltop: parse the mmap data stream Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326100058.GD19826@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=efault@gmx.de \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox