* [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process
@ 2009-03-26 4:55 ideawu
2009-03-27 23:16 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: ideawu @ 2009-03-26 4:55 UTC (permalink / raw)
To: bfields; +Cc: nfsv4@linux-nfs.org, linux-kernel
There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.
Signed-off-by: ideawu <ideawu@163.com>
--------
--- net/sunrpc/svc.c 2009-03-24 07:12:14.000000000 +0800
+++ net/sunrpc/svc.mod.c 2009-03-26 09:39:15.187500000 +0800
@@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
procp = versp->vs_proc + proc;
if (proc >= versp->vs_nproc || !procp->pc_func)
goto err_bad_proc;
- rqstp->rq_server = serv;
rqstp->rq_procinfo = procp;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process
2009-03-26 4:55 [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process ideawu
@ 2009-03-27 23:16 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2009-03-27 23:16 UTC (permalink / raw)
To: ideawu; +Cc: nfsv4@linux-nfs.org, linux-kernel
On Thu, Mar 26, 2009 at 12:55:29PM +0800, ideawu wrote:
> There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.
Thanks! Applied.
>
> Signed-off-by: ideawu <ideawu@163.com>
> --------
>
> --- net/sunrpc/svc.c 2009-03-24 07:12:14.000000000 +0800
> +++ net/sunrpc/svc.mod.c 2009-03-26 09:39:15.187500000 +0800
(But next time please make sure the patch applies with 'patch -p1').
--b.
> @@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
> procp = versp->vs_proc + proc;
> if (proc >= versp->vs_nproc || !procp->pc_func)
> goto err_bad_proc;
> - rqstp->rq_server = serv;
> rqstp->rq_procinfo = procp;
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-27 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-26 4:55 [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process ideawu
2009-03-27 23:16 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox