Re: [PATCH -tip] x86: unification of cpu/bugs.c

Robert Richter
2009-03-26T13:13:46Z

On 26.03.09 17:32:09, Jaswinder Singh Rajput wrote:
> This patch is based on -tip x86/core:
>
> From: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Date: Thu, 26 Mar 2009 17:14:38 +0530
> Subject: [PATCH] x86: unification of cpu/bugs.c
>
> Impact: Unification, cleanup
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/cpu/Makefile | 5 +--
> arch/x86/kernel/cpu/bugs.c | 74 ++++++++++++++++++++++++++--------------
> arch/x86/kernel/cpu/bugs_64.c | 33 ------------------
> 3 files changed, 50 insertions(+), 62 deletions(-)
> delete mode 100644 arch/x86/kernel/cpu/bugs_64.c

Jaswinder,

please send separate patches for separate changes (e.g. make separate
whitespace changes).

[...]

> @@ -91,14 +98,14 @@ static void __init check_hlt(void)
>
> printk(KERN_INFO "Checking 'hlt' instruction... ");
> if (!boot_cpu_data.hlt_works_ok) {
> - printk("disabled\n");
> + printk(KERN_INFO "disabled\n");

All this is continuing the printk above.

-Robert

> return;
> }
> halt();
> halt();
> halt();
> halt();
> - printk("OK.\n");
> + printk(KERN_INFO "OK.\n");
> }
>
> /*
> @@ -122,9 +129,9 @@ static void __init check_popad(void)
> * CPU hard. Too bad.
> */
> if (res != 12345678)
> - printk("Buggy.\n");
> + printk(KERN_INFO "Buggy.\n");
> else
> - printk("OK.\n");
> + printk(KERN_INFO "OK.\n");
> #endif
> }
>

[...]

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com