Re: [PATCH 1/7] block: Add block_flush_device()

Jens Axboe
2009-03-31T06:04:27Z

On Mon, Mar 30 2009, Linus Torvalds wrote:
>
>
> On Mon, 30 Mar 2009, Ric Wheeler wrote:
> >
> > One thing the caller could do is to disable the write cache on the device.
>
> First off, that's not the callers job. If the sysadmin enabled it, some
> random filesystem shouldn't disable it.

Completely agree with that, that is why I want the error logged instead
of returned. The write cache MAY be involved, but it may also be
something entirely different. The cache may be perfectly fine and
ordered but just not supporting flush cache because it doesn't need to
(it has battery backing). The important bit is informing the admin of
the situation, then it's up to the admin to look into the storage stack
and determine if this is a real problem or not. There's nothing the
kernel can do about it.

--
Jens Axboe