Re: relatime: update once per day patches (was: ext3 IO latency measurements)

Andrew Morton
2009-03-26T19:31:01Z

On Thu, 26 Mar 2009 18:49:00 +0000 Matthew Garrett <mjg@redhat.com> wrote:

> On Thu, Mar 26, 2009 at 10:48:43AM -0700, Andrew Morton wrote:
>
> > Oh, the feature itself is desirable. But the interface isn't.
> >
> > - It's a magic number. Maybe someone runs tmpwatch twice per day, or
> > weekly, or...
>
> There has to be a default. 24 hours is a sensible one.

"default" implies that it can be altered by some means.

> When did we adopt a mindset that led to code having to satisfy every
> single user requirement before being accepted, rather than being happy
> with code that provides an incremental improvement over what exists
> already?

Shortcomings have been identified. Weaselly verbiage is not a suitable
way of addressing shortcomings!

Yes, we could (and do) merge things as a halfway step. But when the
features are visible to userspace we just can't do that - we have to
get the interface right on day one, because interfaces are for ever.

(Bear in mind that kernel-does-X-once-per-day _is_ an interface)

> If there are actually users who want to be able to tune this
> per filesystem then I'm sure someone (possibly even me) will write code
> to support them, but right now it just sounds like features for the sake
> of some sense of aesthetic correctness.

A hard-wired global 24-hours constant is in no way superior to a
per-mount tunable. If we're going to do this we should do it in the
best way we know, and we certainly should not lock ourselves into the
inferior implementation for all time by exposing it to userspace.