public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] config: Make need for SCSI_CDROM clearer
@ 2009-03-26 20:54 Alan Cox
  2009-03-26 21:12 ` Matthew Wilcox
  0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2009-03-26 20:54 UTC (permalink / raw)
  To: linux-kernel, linux-scsi

Mention ATAPI. We could insert an essay about libata and ide-scsi etc but
the failure case is someone enables it which is just fine so keep it
simple.

Closes #7736

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
---

 drivers/scsi/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 256c7be..6b5091b 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -121,7 +121,7 @@ config BLK_DEV_SR
 	tristate "SCSI CDROM support"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, FireWire or ATAPI CD-ROM under Linux,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] config: Make need for SCSI_CDROM clearer
  2009-03-26 20:54 [PATCH] config: Make need for SCSI_CDROM clearer Alan Cox
@ 2009-03-26 21:12 ` Matthew Wilcox
  0 siblings, 0 replies; 4+ messages in thread
From: Matthew Wilcox @ 2009-03-26 21:12 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel, linux-scsi

On Thu, Mar 26, 2009 at 08:54:51PM +0000, Alan Cox wrote:
> -	  If you want to use a SCSI or FireWire CD-ROM under Linux,
> +	  If you want to use a SCSI, FireWire or ATAPI CD-ROM under Linux,
>  	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at

Should probably add USB drives here too, since they seem to be getting
more common:

+	  If you want to use a SCSI, FireWire, USB or ATAPI CD-ROM under
+	  Linux, say Y and read the SCSI-HOWTO and the CDROM-HOWTO at

I don't think we need to mention Fibre Channel here ... I'm not
convinced there are any FC CD-ROM drives in existence, and if there are,
they're sufficiently uncommon to not produce bug reports.

Also, should we perhaps add DVD drives here?

+	  If you want to use a CD or DVD drive attached to your computer
+	  by SCSI, FireWire, USB or ATAPI, say Y and read the SCSI-HOWTO
+	  and the CDROM-HOWTO at <http://www.tldp.org/docs.html#howto>.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] config: Make need for SCSI_CDROM clearer
       [not found] <ck4Qt-44e-51@gated-at.bofh.it>
@ 2009-03-27  9:36 ` Bodo Eggert
  2009-03-27 11:08   ` Alan Cox
  0 siblings, 1 reply; 4+ messages in thread
From: Bodo Eggert @ 2009-03-27  9:36 UTC (permalink / raw)
  To: Alan Cox, linux-kernel, linux-scsi

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Mention ATAPI. We could insert an essay about libata and ide-scsi etc but
> the failure case is someone enables it which is just fine so keep it
> simple.

What about:

> +++ b/drivers/scsi/Kconfig
> @@ -121,7 +121,7 @@ config BLK_DEV_SR
>  tristate "SCSI CDROM support"

"CDROM support (except for old IDE and legacy drivers)"?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] config: Make need for SCSI_CDROM clearer
  2009-03-27  9:36 ` Bodo Eggert
@ 2009-03-27 11:08   ` Alan Cox
  0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2009-03-27 11:08 UTC (permalink / raw)
  To: 7eggert; +Cc: linux-kernel, linux-scsi

> "CDROM support (except for old IDE and legacy drivers)"?

I'll update it with Matthews proposed text (which I think is the best)
and resubmit that (probably next week when I get the time to run that
patch around again)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-03-27 11:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-26 20:54 [PATCH] config: Make need for SCSI_CDROM clearer Alan Cox
2009-03-26 21:12 ` Matthew Wilcox
     [not found] <ck4Qt-44e-51@gated-at.bofh.it>
2009-03-27  9:36 ` Bodo Eggert
2009-03-27 11:08   ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox