Re: [GIT PULL] Microblaze initial pack

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> I have noticed one relatively big (but easily fixable) commit 
> structure problem in this tree.
> 
> All of the commits have these tags:
> 
>     Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>     Acked-by: John Linn <john.linn@xilinx.com>
>     Acked-by: John Williams<john.williams@petalogix.com>

I forgot to mention that in any case _your_ signoff as the submitter 
of this tree should be in all commits as well.

So for example this (sample) chain would be fine:

     Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
     Acked-by: John Linn <john.linn@xilinx.com>
     Acked-by: John Williams<john.williams@petalogix.com>
     Signed-off-by: Michal Simek <monstr@monstr.eu>

It's not enough to be listed as the author in the commit. (In any 
case please see Documentation/SubmittingPatches and the DCO 1.1.)

Also, a minor stylistic detail, please fix this:

     John Williams<john.williams@petalogix.com>

to:

     John Williams <john.williams@petalogix.com>

Thanks,

	Ingo