From: "J. Bruce Fields" <bfields@fieldses.org>
To: ideawu <ideawu@163.com>
Cc: "nfsv4@linux-nfs.org" <nfsv4@linux-nfs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process
Date: Fri, 27 Mar 2009 19:16:34 -0400 [thread overview]
Message-ID: <20090327231634.GE18222@fieldses.org> (raw)
In-Reply-To: <200903261255292962249@163.com>
On Thu, Mar 26, 2009 at 12:55:29PM +0800, ideawu wrote:
> There is no need to set rqstp->rq_server to serv, while serv is initialized as rqstp->rq_server at previous line. And between these two lines, there is no change to rqstp->rq_server.
Thanks! Applied.
>
> Signed-off-by: ideawu <ideawu@163.com>
> --------
>
> --- net/sunrpc/svc.c 2009-03-24 07:12:14.000000000 +0800
> +++ net/sunrpc/svc.mod.c 2009-03-26 09:39:15.187500000 +0800
(But next time please make sure the patch applies with 'patch -p1').
--b.
> @@ -1093,7 +1093,6 @@ svc_process(struct svc_rqst *rqstp)
> procp = versp->vs_proc + proc;
> if (proc >= versp->vs_nproc || !procp->pc_func)
> goto err_bad_proc;
> - rqstp->rq_server = serv;
> rqstp->rq_procinfo = procp;
>
>
>
prev parent reply other threads:[~2009-03-27 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 4:55 [PATCH]sunrpc/svc.c: Remove unused line 'rqstp->rq_server = serv;' in svc_process ideawu
2009-03-27 23:16 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327231634.GE18222@fieldses.org \
--to=bfields@fieldses.org \
--cc=ideawu@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox