From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [RESENT] platform_driver's probe functions must not be located in .init.text
Date: Sat, 28 Mar 2009 00:21:53 +0100 [thread overview]
Message-ID: <20090327232153.GA16348@pengutronix.de> (raw)
Hello,
[A very similar series was already posted in January this year, but only
a few patches made it into Linus' tree. I updated my patches to Linus'
current master and added a few new fixes. See
http://thread.gmane.org/gmane.linux.kernel/779532
for the old version. Now I made the effort to find out people to Cc:
for each patch, so I hope to get more patches in this time.]
if the probe function of a platform_driver lives in .init.text (i.e. is
defined using __init) registering a device after the .init sections are
discarded results in an oops. You can test that by doing
echo $drivername.$somevalidid > /sys/bus/platform/drivers/$drivername/unbind
echo $drivername.$somevalidid > /sys/bus/platform/drivers/$drivername/bind
As a reply to this mail I send 58 patches that fix this kind of error by
moving the respective probe functions to .devinit.text.
This should be safe in general as it only increases the lifetime for the
respective functions.
The alternative is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver. But I choosed changing the section as
this is less intrusive though probably the latter would be the better
fix because it saves some memory.
You cannot blindly change to use platform_driver_probe because if the
devices are only registered after that call (but while .init is still
valid) the driver is already gone. This is hardly checkable for me
because I don't have the hardware for most drivers I fixed.
Shortlog and diffstat are below. You can fetch this series from
git://git.pengutronix.de/git/ukl/linux-2.6.git platsection-master
based on v2.6.29-3321-gbe0ea69.
Best regards
Uwe
Uwe Kleine-König (58):
move acornfb's probe function to .devinit.text
move am79c961's probe function to .devinit.text
move arcfb's probe function to .devinit.text
move at91_ether's probe function to .devinit.text
move at91_wdt's probe function to .devinit.text
move bf54x-lq043's probe function to .devinit.text
move cfag12864bfb's probe function to .devinit.text
move leds-clevo-mail's probe function to .devinit.text
move cobalt-lcd's probe function to .devinit.text
move corgi-ssp's probe function to .devinit.text
move efifb's probe function to .devinit.text
move orion-ehci's probe function to .devinit.text
move epson1355fb's probe function to .devinit.text
move sh_flctl's probe function to .devinit.text
move gbefb's probe function to .devinit.text
move h1940-bt's probe function to .devinit.text
move h1940-leds's probe function to .devinit.text
move hgafb's probe function to .devinit.text
move hitfb's probe function to .devinit.text
move hp680-bl's probe function to .devinit.text
move hp-wmi's probe function to .devinit.text
move jazzsonic's probe function to .devinit.text
move jornada_ssp's probe function to .devinit.text
move ks8695_wdt's probe function to .devinit.text
move macsonic's probe function to .devinit.text
move meth's probe function to .devinit.text
move mmci-omap's probe function to .devinit.text
move mailbox's probe function to .devinit.text
move omap24xxcam's probe function to .devinit.text
move mailbox's probe function to .devinit.text
move omap_hdq's probe function to .devinit.text
move i2c_omap's probe function to .devinit.text
move mmci-omap-hs's probe function to .devinit.text
move omap_rng's probe function to .devinit.text
move omap_wdt's probe function to .devinit.text
move orion_nand's probe function to .devinit.text
move gen_nand's probe function to .devinit.text
move q40fb's probe function to .devinit.text
move r8a66597_hcd's probe function to .devinit.text
move s3c241xfb's probe function to .devinit.text
move sa11x0-fb's probe function to .devinit.text
move flash's probe function to .devinit.text
move sb1250-mac's probe function to .devinit.text
move sgiseeq's probe function to .devinit.text
move sgivwfb's probe function to .devinit.text
move sgiwd93's probe function to .devinit.text
move sharpsl-pm's probe function to .devinit.text
move sh_mobile_lcdc_fb's probe function to .devinit.text
move snd_powermac's probe function to .devinit.text
move snirm_53c710's probe function to .devinit.text
move stk17ta8's probe function to .devinit.text
move twl4030_usb's probe function to .devinit.text
move omap_udc's probe function to .devinit.text
move vesafb's probe function to .devinit.text
move vfb's probe function to .devinit.text
move vga16fb's probe function to .devinit.text
move w100fb's probe function to .devinit.text
move xtsonic's probe function to .devinit.text
arch/arm/common/sharpsl_pm.c | 2 +-
arch/arm/mach-omap1/mailbox.c | 2 +-
arch/arm/mach-omap2/mailbox.c | 2 +-
arch/arm/mach-pxa/corgi_ssp.c | 2 +-
arch/arm/mach-s3c2410/h1940-bluetooth.c | 2 +-
arch/arm/mach-sa1100/jornada720_ssp.c | 2 +-
drivers/auxdisplay/cfag12864bfb.c | 2 +-
drivers/char/hw_random/omap-rng.c | 2 +-
drivers/i2c/busses/i2c-omap.c | 2 +-
drivers/leds/leds-clevo-mail.c | 2 +-
drivers/leds/leds-h1940.c | 2 +-
drivers/media/video/omap24xxcam.c | 2 +-
drivers/mmc/host/omap.c | 2 +-
drivers/mmc/host/omap_hsmmc.c | 2 +-
drivers/mtd/maps/sa1100-flash.c | 2 +-
drivers/mtd/nand/orion_nand.c | 2 +-
drivers/mtd/nand/plat_nand.c | 2 +-
drivers/mtd/nand/sh_flctl.c | 2 +-
drivers/net/arm/am79c961a.c | 2 +-
drivers/net/arm/at91_ether.c | 2 +-
drivers/net/jazzsonic.c | 2 +-
drivers/net/macsonic.c | 2 +-
drivers/net/meth.c | 2 +-
drivers/net/sb1250-mac.c | 2 +-
drivers/net/sgiseeq.c | 2 +-
drivers/net/xtsonic.c | 2 +-
drivers/platform/x86/hp-wmi.c | 4 ++--
drivers/rtc/rtc-stk17ta8.c | 2 +-
drivers/scsi/sgiwd93.c | 2 +-
drivers/scsi/sni_53c710.c | 2 +-
drivers/usb/gadget/omap_udc.c | 2 +-
drivers/usb/host/ehci-orion.c | 2 +-
drivers/usb/host/r8a66597-hcd.c | 2 +-
drivers/usb/otg/twl4030-usb.c | 2 +-
drivers/video/acornfb.c | 2 +-
drivers/video/arcfb.c | 2 +-
drivers/video/backlight/hp680_bl.c | 2 +-
drivers/video/bf54x-lq043fb.c | 2 +-
drivers/video/cobalt_lcdfb.c | 2 +-
drivers/video/efifb.c | 2 +-
drivers/video/epson1355fb.c | 2 +-
drivers/video/gbefb.c | 2 +-
drivers/video/hgafb.c | 2 +-
drivers/video/hitfb.c | 2 +-
drivers/video/q40fb.c | 2 +-
drivers/video/s3c2410fb.c | 4 ++--
drivers/video/sa1100fb.c | 2 +-
drivers/video/sgivwfb.c | 2 +-
drivers/video/sh_mobile_lcdcfb.c | 2 +-
drivers/video/vesafb.c | 2 +-
drivers/video/vfb.c | 2 +-
drivers/video/vga16fb.c | 2 +-
drivers/video/w100fb.c | 2 +-
drivers/w1/masters/omap_hdq.c | 4 ++--
drivers/watchdog/at91rm9200_wdt.c | 2 +-
drivers/watchdog/ks8695_wdt.c | 2 +-
drivers/watchdog/omap_wdt.c | 2 +-
sound/ppc/powermac.c | 2 +-
58 files changed, 61 insertions(+), 61 deletions(-)
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2009-03-27 23:22 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 23:21 Uwe Kleine-König [this message]
2009-03-27 23:26 ` [PATCH 01/58] move acornfb's probe function to .devinit.text Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 02/58] move am79c961's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 03/58] move arcfb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 04/58] move at91_ether's " Uwe Kleine-König
2009-03-28 0:09 ` David Brownell
2009-03-28 6:32 ` Uwe Kleine-König
2009-03-28 16:27 ` David Brownell
2009-04-02 17:47 ` [PATCH] make mmci-omap using platform_driver_probe Uwe Kleine-König
2009-04-02 17:51 ` Uwe Kleine-König
2009-04-16 20:53 ` David Brownell
2009-04-28 19:27 ` Pierre Ossman
2009-04-28 22:11 ` David Brownell
2009-03-27 23:26 ` [PATCH 05/58] move at91_wdt's probe function to .devinit.text Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 06/58] move bf54x-lq043's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 07/58] move cfag12864bfb's " Uwe Kleine-König
2009-03-28 18:43 ` Miguel Ojeda
2009-03-27 23:26 ` [PATCH 08/58] move leds-clevo-mail's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 09/58] move cobalt-lcd's " Uwe Kleine-König
2009-03-28 10:43 ` Ralf Baechle
2009-03-27 23:26 ` [PATCH 10/58] move corgi-ssp's " Uwe Kleine-König
2009-03-28 9:31 ` Eric Miao
2009-03-27 23:26 ` [PATCH 11/58] move efifb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 12/58] move orion-ehci's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 13/58] move epson1355fb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 14/58] move sh_flctl's " Uwe Kleine-König
2009-03-30 2:26 ` Yoshihiro Shimoda
2009-03-27 23:26 ` [PATCH 15/58] move gbefb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 16/58] move h1940-bt's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 17/58] move h1940-leds's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 18/58] move hgafb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 19/58] move hitfb's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 20/58] move hp680-bl's " Uwe Kleine-König
2009-03-28 9:25 ` Kristoffer Ericson
2009-03-27 23:26 ` [PATCH 21/58] move hp-wmi's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 22/58] move jazzsonic's " Uwe Kleine-König
2009-03-28 8:40 ` Geert Uytterhoeven
2009-03-28 10:45 ` Ralf Baechle
2009-03-28 19:25 ` [PATCH] " Uwe Kleine-König
2009-03-29 8:55 ` Geert Uytterhoeven
2009-03-27 23:26 ` [PATCH 23/58] move jornada_ssp's " Uwe Kleine-König
2009-03-28 9:26 ` Kristoffer Ericson
2009-03-27 23:26 ` [PATCH 24/58] move ks8695_wdt's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 25/58] move macsonic's " Uwe Kleine-König
2009-03-28 8:39 ` Geert Uytterhoeven
2009-03-28 19:33 ` [PATCH] " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 26/58] move meth's " Uwe Kleine-König
2009-03-28 10:45 ` Ralf Baechle
2009-03-27 23:26 ` [PATCH 27/58] move mmci-omap's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 28/58] move mailbox's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 29/58] move omap24xxcam's " Uwe Kleine-König
2009-04-01 7:40 ` Sakari Ailus
2009-04-01 8:28 ` Uwe Kleine-König
2009-04-01 9:02 ` Sakari Ailus
2009-04-01 8:36 ` Trilok Soni
2009-03-27 23:26 ` [PATCH 30/58] move mailbox's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 31/58] move omap_hdq's " Uwe Kleine-König
2009-03-28 8:21 ` Evgeniy Polyakov
2009-03-28 19:37 ` Uwe Kleine-König
2009-03-28 20:53 ` Evgeniy Polyakov
2009-03-27 23:26 ` [PATCH 32/58] move i2c_omap's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 33/58] move mmci-omap-hs's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 34/58] move omap_rng's " Uwe Kleine-König
2009-03-29 7:47 ` Herbert Xu
2009-03-29 19:03 ` David Brownell
2009-03-27 23:26 ` [PATCH 35/58] move omap_wdt's " Uwe Kleine-König
2009-03-29 18:09 ` Wim Van Sebroeck
2009-03-29 18:15 ` Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 36/58] move orion_nand's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 37/58] move gen_nand's " Uwe Kleine-König
2009-03-27 23:26 ` [PATCH 38/58] move q40fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 39/58] move r8a66597_hcd's " Uwe Kleine-König
2009-03-30 2:26 ` Yoshihiro Shimoda
2009-03-27 23:27 ` [PATCH 40/58] move s3c241xfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 41/58] move sa11x0-fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 42/58] move flash's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 43/58] move sb1250-mac's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 44/58] move sgiseeq's " Uwe Kleine-König
2009-03-28 10:45 ` Ralf Baechle
2009-03-27 23:27 ` [PATCH 45/58] move sgivwfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 46/58] move sgiwd93's " Uwe Kleine-König
2009-03-28 10:46 ` Ralf Baechle
2009-03-27 23:27 ` [PATCH 47/58] move sharpsl-pm's " Uwe Kleine-König
2009-03-28 9:32 ` Eric Miao
2009-03-28 19:38 ` Uwe Kleine-König
2009-03-29 1:23 ` Eric Miao
2009-03-27 23:27 ` [PATCH 48/58] move sh_mobile_lcdc_fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 49/58] move snd_powermac's " Uwe Kleine-König
2009-04-06 2:09 ` Takashi Iwai
2009-03-27 23:27 ` [PATCH 50/58] move snirm_53c710's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 51/58] move stk17ta8's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 52/58] move twl4030_usb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 53/58] move omap_udc's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 54/58] move vesafb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 55/58] move vfb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 56/58] move vga16fb's " Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 57/58] move w100fb's " Uwe Kleine-König
2009-03-28 10:01 ` pHilipp Zabel
2009-03-28 19:13 ` Uwe Kleine-König
2009-03-27 23:27 ` [PATCH 58/58] move xtsonic's " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327232153.GA16348@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox